Change to conditionally attach only needed local or remote video libraries

Created on 22 June 2022, over 2 years ago
Updated 7 September 2023, over 1 year ago

Problem/Motivation

Remote video libraries are currently being attached and included without checking whether the site has remote video media header or not.

Steps to reproduce

Given that I have a site with varbase media header block
When the site only has images media header only in the page
Then video.media-header.vimeo.js and video.media-header.youtube.js should not be attached to the page. On the other hand, if I have a page with a youtube media header then video.media-header.youtube.js should be attached only to that page only.

Proposed resolution

Check what the media provider type the varbase media header has and attach the corresponding library accordingly.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.7 , varbase_media_header-9.0.3 , varbase_media_header-10.0.0-alpha1

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Test Varbase Media Header - Image

Test Varbase Media Header - Local Video

Test Varbase Media Header - Remote Youtube Video

Test Varbase Media Header - Remote Vimeo Video

💬 Support request
Status

Fixed

Version

9.0

Component

Code

Created by

🇯🇴Jordan omar alahmed Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024