Event data should be passed as object

Re the question in #6 above:

All events generated by facebook_pixel or facebook_pixel_commerce are funnelled through facebook_pixel_page_attachments() which runs Xss::filter(json_encode($event['data']) on the event data.

I think it is therefore a safe assumption that once you get to the client-side javascript where initTracking() loops over drupalSettings.facebook_pixel.events, that events['data'] will be JSON-encoded, so doing JSON.parse() is appropriate without needing to check if events['data'] is already an object.

Uploading the change in #2 as a patch so it's more easily usable while we wait for the maintainer to merge this.

Giving this another RTBC. And no, I've no idea how many RTBCs an issue needs :-)

Thank you all! Merged into dev!

Automatically closed - issue fixed for 2 weeks with no activity.