- šµšPhilippines cleavinjosh
Hi @nitin_lama,
I applied patch #8 and it was applied smoothly.
However, I still encountered some issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.ā livesearch_person git:(1.0.x) curl https://www.drupal.org/files/issues/2022-07-01/3290851-fixing-coding-standard-8.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 53912 100 53912 0 0 100k 0 --:--:-- --:--:-- --:--:-- 100k patching file js/livesearch_person.webapijs.js patching file livesearch_person.module patching file src/Controller/LiveSearchPersonController.php patching file src/Form/LiveSearchConfigForm.php patching file src/Form/LiveSearchPersonTestConnectionForm.php patching file src/Form/LiveSearchPersonWebformForm.php patching file src/LiveSearchPersonInterface.php patching file src/LiveSearchPersonService.php ā livesearch_person git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml livesearch_person FILE: ...te/drupal-org-issues/web/modules/contrib/livesearch_person/livesearch_person.module ----------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------- 45 | WARNING | Unused variable $i. ----------------------------------------------------------------------------------------- FILE: ...sues/web/modules/contrib/livesearch_person/src/Form/LiveSearchPersonWebformForm.php ----------------------------------------------------------------------------------------- FOUND 149 ERRORS AND 2 WARNINGS AFFECTING 144 LINES ----------------------------------------------------------------------------------------- 12 | WARNING | [ ] The class short comment should describe what the class does and not | | simply repeat the class name 14 | ERROR | [x] Opening brace should be on the same line as the declaration 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Opening brace should be on the same line as the declaration 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Opening brace should be on the same line as the declaration 43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Opening brace should be on the same line as the declaration 53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 59 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found | | "null" 60 | ERROR | [x] Opening brace should be on the same line as the declaration 61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 63 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 65 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found | | "null" 66 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 67 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 68 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 69 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 70 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 72 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 74 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 75 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 77 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 79 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 80 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found | | "true" 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 88 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 89 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 90 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 90 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found | | "false" 93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 94 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 95 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 96 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 100 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 101 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 102 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 103 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 106 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 107 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 108 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 109 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 112 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 113 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 114 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 115 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 116 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 119 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 120 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 121 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 122 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 122 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found | | "true" 125 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 126 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 129 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 130 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 131 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 132 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 133 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 134 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 134 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found | | "null" 136 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 137 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 139 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 140 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 142 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 143 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 144 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 145 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 146 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 147 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 148 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 151 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 152 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 153 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 154 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 155 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 156 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 157 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 158 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 159 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 162 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 163 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 164 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 165 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 168 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 174 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 174 | WARNING | [ ] Possible useless method overriding detected 175 | ERROR | [x] Opening brace should be on the same line as the declaration 176 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 182 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 183 | ERROR | [x] Opening brace should be on the same line as the declaration 184 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 185 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 186 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 187 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 189 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 190 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 191 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 193 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 194 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 196 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 201 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 202 | ERROR | [x] Opening brace should be on the same line as the declaration 203 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 204 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 206 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 211 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 212 | ERROR | [x] Opening brace should be on the same line as the declaration 213 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 214 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 215 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 216 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 217 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 219 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 224 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 225 | ERROR | [x] Opening brace should be on the same line as the declaration 226 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 227 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 228 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 229 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 230 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 231 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 232 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 ----------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 149 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------- FILE: ...b/modules/contrib/livesearch_person/src/Form/LiveSearchPersonTestConnectionForm.php ----------------------------------------------------------------------------------------- FOUND 56 ERRORS AND 3 WARNINGS AFFECTING 56 LINES ----------------------------------------------------------------------------------------- 13 | WARNING | [ ] The class short comment should describe what the class does and not | | simply repeat the class name 15 | ERROR | [x] Opening brace should be on the same line as the declaration 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [x] Opening brace should be on the same line as the declaration 29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Opening brace should be on the same line as the declaration 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 46 | ERROR | [x] Opening brace should be on the same line as the declaration 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [x] Opening brace should be on the same line as the declaration 55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 56 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 57 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 58 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 59 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 60 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 60 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found | | "true" 63 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 64 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 65 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 75 | ERROR | [x] Opening brace should be on the same line as the declaration 76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 76 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency | | injection instead 77 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 78 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 79 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 91 | ERROR | [x] Opening brace should be on the same line as the declaration 92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 93 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12 100 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found | | "true" 103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 104 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 105 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 105 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency | | injection instead 111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 ----------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 56 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------- FILE: ...-org-issues/web/modules/contrib/livesearch_person/src/Form/LiveSearchConfigForm.php ----------------------------------------------------------------------------------------- FOUND 52 ERRORS AND 2 WARNINGS AFFECTING 51 LINES ----------------------------------------------------------------------------------------- 10 | WARNING | [ ] The class short comment should describe what the class does and not | | simply repeat the class name 12 | ERROR | [x] Opening brace should be on the same line as the declaration 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Opening brace should be on the same line as the declaration 19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 20 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [x] Opening brace should be on the same line as the declaration 29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Opening brace should be on the same line as the declaration 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 40 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 41 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 42 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 43 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 43 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found | | "true" 44 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 48 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 49 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 50 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 51 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 51 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found | | "true" 54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 55 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 56 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 57 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | WARNING | [ ] Possible useless method overriding detected 66 | ERROR | [x] Opening brace should be on the same line as the declaration 67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 74 | ERROR | [x] Opening brace should be on the same line as the declaration 75 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 77 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 78 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found | | 12 80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 81 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 ----------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 52 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------- FILE: ...al-org-issues/web/modules/contrib/livesearch_person/src/LiveSearchPersonService.php ----------------------------------------------------------------------------------------- FOUND 124 ERRORS AND 1 WARNING AFFECTING 120 LINES ----------------------------------------------------------------------------------------- 12 | ERROR | [x] Opening brace should be on the same line as the declaration 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Opening brace should be on the same line as the declaration 43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 44 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency | | injection instead 45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 59 | ERROR | [x] Opening brace should be on the same line as the declaration 60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 62 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 63 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 63 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found | | "false" 64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 65 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Opening brace should be on the same line as the declaration 82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 83 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 86 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 87 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 88 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 89 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 89 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found | | "false" 90 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 91 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 92 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 101 | ERROR | [x] Opening brace should be on the same line as the declaration 102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 103 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 104 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 106 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 114 | ERROR | [x] Opening brace should be on the same line as the declaration 115 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 116 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 117 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 118 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 120 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 124 | ERROR | [x] Opening brace should be on the same line as the declaration 125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 126 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 130 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 134 | ERROR | [x] Opening brace should be on the same line as the declaration 135 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 136 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 137 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 138 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 140 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 143 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found | | "true" 144 | ERROR | [x] Opening brace should be on the same line as the declaration 145 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 146 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 147 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 148 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 149 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 150 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 151 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 153 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 156 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 157 | ERROR | [x] Opening brace should be on the same line as the declaration 158 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 159 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 160 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 161 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 163 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 166 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 167 | ERROR | [x] Opening brace should be on the same line as the declaration 168 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 169 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 170 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 173 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 180 | ERROR | [x] Expected 1 spaces after parameter type; 2 found 180 | ERROR | [ ] Doc comment for parameter $options does not match actual variable | | name <undefined> 186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 187 | ERROR | [x] Opening brace should be on the same line as the declaration 189 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 192 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 193 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 194 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 198 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 200 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 203 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 204 | ERROR | [x] Opening brace should be on the same line as the declaration 205 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 206 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 207 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 208 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 209 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 210 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 211 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 212 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 214 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 ----------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 123 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------- FILE: ...web/modules/contrib/livesearch_person/src/Controller/LiveSearchPersonController.php ----------------------------------------------------------------------------------------- FOUND 30 ERRORS AND 1 WARNING AFFECTING 31 LINES ----------------------------------------------------------------------------------------- 13 | WARNING | [ ] The class short comment should describe what the class does and not | | simply repeat the class name 15 | ERROR | [x] Opening brace should be on the same line as the declaration 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [x] Opening brace should be on the same line as the declaration 29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Opening brace should be on the same line as the declaration 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 46 | ERROR | [x] Opening brace should be on the same line as the declaration 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 48 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 51 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 52 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 53 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 54 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 55 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 58 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 ----------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------- FILE: ...-org-issues/web/modules/contrib/livesearch_person/src/LiveSearchPersonInterface.php ----------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ----------------------------------------------------------------------------------------- 9 | ERROR | [x] Opening brace should be on the same line as the declaration 11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 ----------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------- Time: 268ms; Memory: 10MB ā contrib git:(main) āThank you.
- Status changed to Needs review
6 months ago 10:35am 18 July 2024 - šµšPhilippines cleavinjosh
Hi,
Please review MR!1. These are the issues remaining:
ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml livesearch_person FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/livesearch_person/livesearch_person.module --------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 45 | WARNING | Unused variable $i. --------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/livesearch_person/src/Form/LiveSearchPersonWebformForm.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------- 12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name 169 | WARNING | Possible useless method overriding detected ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/livesearch_person/src/Form/LiveSearchPersonTestConnectionForm.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------- 13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name 70 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 98 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead -------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/livesearch_person/src/Form/LiveSearchConfigForm.php ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 10 | WARNING | The class short comment should describe what the class does and not simply repeat the class name 61 | WARNING | Possible useless method overriding detected ------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/livesearch_person/src/LiveSearchPersonService.php ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------- 42 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 169 | ERROR | Doc comment for parameter $options does not match actual variable name <undefined> ---------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/livesearch_person/src/Controller/LiveSearchPersonController.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------ 13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ------------------------------------------------------------------------------------------------------------------------------------ Time: 309ms; Memory: 10MB ā contribThank you.