Automated Drupal 10 compatibility fixes

Guillaume Aveline → made their first commit to this issue’s fork.

Guillaume Aveline → closed merge request !3

Sorry for double merge request. :)

+ 1 RTBC

Not sure if there are active maintainers

The patch at #3 is no longer applying when used with cewegans/composer-patches and a standard composer require 'drupal/simple_pass_reset:^1.1'.

I'm going to leave the patch at #3 as current though as that does still apply to the dev branch.

If people are needing this for a production environment and don't use dev branches in prod, the attached will work for you.

For the life of me, I can't get the patches in #3 and #11 to work, so I'm trying this.

Hmm... Odd. "It works for me." :)

@carsonw, I should be able to test this again this week. I'll let you know how it goes and if it applies fine I'll ditch my one.

Cheers for testing.

Neither patch 11 or 12 is applying against drupal/simple_pass_reset:dev-1.x#4041f81.

Looks like a standard core/core_version_requirement fix - let me roll my own...

Ahh, it's identical to patch #2, which applies just fine against dev-1.x#4041f81

@carsonw, @Gold, I wonder if you're patching the dev version or the release version?

This patch works for us as well. It looks GTG to me.

I suggest we keep the patch from the update bot. The MR adds different constraints that are not necessary.

Made the simple update and tested in a D10 site. I did not do a thorough test of the module, small as it is, for deprecations or PHP warnings, but I'll tag a release now that at least adds D10 support and we can catch any issues in follow-ups.

Thanks Ryan! (Hope you're well)

Automatically closed - issue fixed for 2 weeks with no activity.