Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 16 June 2022, over 2 years ago
Updated 15 June 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 years ago →
    🇺🇸United States mile23 Seattle, WA

    It seems that there's already a commit for this issue at https://git.drupalcode.org/project/select_or_other/-/commit/ae0585ff8cc5...

    This issue improves PHP 8.1 compatibility for tests and is worthwhile.

    It'd be great to have a roadmap to a release that supports Drupal 10, but for now 4.x-dev works, and this patch enhances it.

    Verified that the patch applies, and that it can be installed using Drupal 9.5.x and 10.0.x, using both PHP 7.4 and 8.1.

  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇳India prashant.c Dharamshala

    There are following errors identified by drupal-check, a few of them seem critical:

     ------ ----------------------------------------------------------------------- 
  Line   src/Plugin/Validation/AllowedValuesConstraintValidator.php             
 ------ ----------------------------------------------------------------------- 
  61     Access to an undefined property                                        
         Symfony\Component\Validator\Constraint::$choices.                      
  137    Call to an undefined method                                            
         Drupal\Core\TypedData\DataDefinitionInterface::getMainPropertyName().  
  141    Call to an undefined method                                            
         Drupal\Core\TypedData\TypedDataInterface::get().                       
 ------ ----------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------- 
  Line   tests/src/Unit/ListWidgetTest.php                                                        
 ------ ----------------------------------------------------------------------------------------- 
  90     Variable $mock in PHPDoc tag @var does not match assigned variable                       
         $test_values.                                                                            
  110    Variable $mock in PHPDoc tag @var does not match assigned variable                       
         $result.                                                                                 
  122    Variable $mock in PHPDoc tag @var does not match assigned variable                       
         $result.                                                                                 
  201    PHPDoc tag @param for parameter $fieldDefinition with type                               
         Drupal\Core\Field\FieldDefinitionInterface|PHPUnit\Framework\MockObject\MockObject|null  
         is not subtype of native type                                                            
         Drupal\Core\Field\FieldDefinitionInterface|null.                                         
 ------ ----------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------- 
  Line   tests/src/Unit/ReferenceWidgetTest.php                                      
 ------ ---------------------------------------------------------------------------- 
  154    Call to an undefined method                                                 
         Drupal\select_or_other\Plugin\Field\FieldWidget\ReferenceWidget::method().  
 ------ ---------------------------------------------------------------------------- 

 ------ -------------------------------------------------------- 
  Line   tests/src/Unit/UnitTestBase.php                         
 ------ -------------------------------------------------------- 
  58     Variable $container in PHPDoc tag @var does not exist.  
 ------ -------------------------------------------------------- 

 [ERROR] Found 9 errors
  • Comment almost 2 years ago →
    🇦🇺Australia acbramley

    Those are phpstan errors, they can be fixed in a separate issue.

  • Status changed to RTBC almost 2 years ago
  • Comment almost 2 years ago →
    🇪🇪Estonia ValkaTR

    is it ok to use "select or other" module in drupal 10 already?

  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇧🇪Belgium daften

    I am not incorporating any further patches through this issue. Other fixes were done through issues like #3239671: Fixing test in 4.x Branch → and the earlier commit in here. Testing the latest dev version shows no issues by upgrade_status. Any further fixes that are needed should go through different issues, including the cosmetic changes. Those are very welcome of course, but I'd prefer to keep issues centered on their scope :)

    There will be a release for select_or_other with D10 compatibility in less than an hour, sorry for the delays!

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024