Automated Drupal 10 compatibility fixes

There is a deprecated function that needs to be fixed for Drupal 10.

Error: Call to undefined method Drupal\Core\Extension\ModuleHandler::getImplmentations() in recode_save() (line308 of modules/contrib/regcode.module).

Here is the change record for this:

https://www.drupal.org/node/3000490 →

Please review the patch.

The Patch identified in #6 worked to resolve the issue reported in #5. Tested and working in Drupal 10, PHP 8.1.

Just because you don't get an error doesn't mean it works. It is clearly wrong if you just look at the patch.

• The replacement code is identical for the two hooks, but it should not be because these are different hooks.
• Likewise, the closure is passed the wrong variables in the first case.
• Additionally, invokeAllWith() was introduced in Drupal 9.4, so there is no way this change is compatible with ^8.8.2 or with ^9. The dependency changes in the patch are wrong.

My preference would be to add a simple test case to make sure the hook invocations work as designed - this test case should run in D9 and D10 and that will help to ensure the hook invocations were ported correctly. A test case would also reveal the problem with the dependencies.

Nitesh Sethia → made their first commit to this issue’s fork.

Created a patch for version compatibility.

@tcmktg: You assigned this to yourself - are you going to work on it?

As a non developer who is reliant on this module, I shall be very grateful for a D10-compatible release asap.

I am resetting the Assigned field, since the person to which the issue was assigned has not worked on it since October, 2023.

I apologize for bumping this issue.

Updated the code and the patch was missing few changes.

Hey Nitesh Sethia,

It looks to me like you have bought the broken changes from #6 (Invalid hook arguments etc, see full list in #9) into the MR.

The work I added to the MR was to address some of the issue raised (specifically arround hook parameteres) in #9. This work was intended as a replacement for the work done in #6. It looks like you've added the work from #6 back?

(Sorry I should have made that clearer when I added the changes)

Cheers!

Thanks to @lind101 for working out a solution to this!

To use this on fresh installation and apply the working patch on #15, we had to

1. refer to the lenient endpoint package → allowing to bypass version requirements
2. add the regcode module as an exception
3. successfully requiring the module, after which the
4. the patch file of the drupacode merge could be applied to fix the behaviour

(props to @morenstrat → for pointing to the lenient plugin)

Thank you Stolzenhain. Do you or anyone else know how/when this could be rolled into a release?

There is nothing here that is D10-specific except for the changes to regcode.info.yml. And those are done wrong.

The supported core versions for this module have already been changed to ^9.4 | ^10 by commit a849b4b0

The change to the hook invocations will be solved in 📌 [9.4] All hook invocation delegated to Module Handler service Fixed .
I have opened up an MR in that issue and uploaded the patch by @lind101 from #15 above. That is the only valid patch that has been posted here.

Closing this issue as "outdated" so that the project update bot will stop auto posting.