Automated Drupal 10 compatibility fixes

As best I can tell, my local testing suggests the patch in #4 works against 8.x-2.6 (so log as I change info.yml to permit Drupal 10), but when I attempted to create a fork against 8.x-2.x-dev, the patch fails to apply.

I'm going to assume there have been changes since 2.6 for a reason. But one vote up for this automated patch still working in D10.

OK, an update.

I've mostly gotten Patch #4 to work for D10, with modifications. There are flaws, one of them I can't fix without context.

Again, patch #4 applies only against 8.x-2.6, not the current dev branch.

Current fixes to get things mostly working:

Apply patch #4 to 8.x-2.6

Change private_taxonomy.info.yml to permit version ^10

Modify line 115 of src/Plugin/Field/FieldWidget/PrivateTaxonomyAutocompleteWidget.php:
'#autocomplete_route_name' => $this->getSetting('autocomplete_route_name'),
(the old function was deprecated)

I thought everything looked great, but then I pointed PHPStan against it. I found a few faults in src/Type/PrivateTaxonomyTermReferenceItem.php:

It makes reference to several classes without referring to them in a use clause - I added them in manually:

use Drupal\Core\Entity\EntityTypeInterface;
use Drupal\Core\Entity\FieldableEntityInterface;
use Drupal\Core\Entity\TypedData\EntityDataDefinition;
use Drupal\Core\Field\FieldItemBase;
use Drupal\Core\Field\FieldStorageDefinitionInterface;
use Drupal\Core\StringTranslation\TranslatableMarkup;
use Drupal\Core\TypedData\DataReferenceDefinition;
use Drupal\Core\TypedData\DataReferenceTargetDefinition;

Also, one bug I can't fix. propertyDefinitions() makes reference to $target_type_info twice, but doesn't define it.

Anyways, TLDR, Patch #4 is pretty close, would be good to get it to apply against dev to get things moving forward.

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.

Therefore this patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. mglaman/phpstan-drupal: 1.1.35
2. palantirnet/drupal-rector: 0.15.1

Attached a updated patch starting from #9 and the reports of #8 and drupal-rector and drupal-phpstan

• src/Plugin/Field/FieldWidget/PrivateTaxonomyAutocompleteWidget.php: Call to deprecated function taxonomy_implode_tags().
• src/Type/PrivateTaxonomyTermReferenceItem.php : missing import of various classes, $target_type_info not defined

Personally I haven't tried the patch yet, but at least from automatic tools reviews the module should be D10 ready.

pp.panatom → made their first commit to this issue’s fork.

I have reviewed and applied patch #10 this works for Drupal 9.5.11 and Drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5.11 have been attached for reference:

can be moved to RTBC+1

Sending back to Needs review as we can’t trust Specbee reports. There is nothing in comment #12 that indicates anything other than what DrupalCi would have already tested.

Specbee (including this specific user) has been seen to not fully test issues and may just be attempting to gain credits for their D.O. partner rating.

More importantly, this module is basically un-maintained at the moment. If someone is going to want to see issues closed out they are going to need to consider stepping up and working on the rest of the queue to show their interest in maintaining the code.

patch #10 and private_taxonomy 8.x-2.6:

patching file private_taxonomy.info.yml
patching file src/Plugin/Field/FieldWidget/PrivateTaxonomyAutocompleteWidget.php
patching file src/Type/PrivateTaxonomyTermReferenceItem.php
patching file tests/src/Functional/PrivateTaxonomyPermissionsTest.php
Hunk #3 succeeded at 35 with fuzz 2.
Hunk #4 succeeded at 41 (offset -8 lines).
Hunk #5 succeeded at 109 (offset -12 lines).
Hunk #6 succeeded at 199 (offset -8 lines).
Hunk #7 succeeded at 265 (offset -8 lines).
Hunk #8 FAILED at 306.
1 out of 8 hunks FAILED -- saving rejects to file tests/src/Functional/PrivateTaxonomyPermissionsTest.php.rej
patching file tests/src/Functional/PrivateTaxonomySettingsTest.php
patching file tests/src/Functional/PrivateTaxonomyTestBase.php
patching file tests/src/Functional/PrivateTaxonomyTokensTest.php
patching file tests/src/Functional/PrivateTaxonomyUnitTest.php
patching file tests/src/Functional/PrivateTaxonomyViewsTest.php