Automated Drupal 10 compatibility fixes

Everything looks good in terms of D10 readiness. Here's the bump to core_version_requirement.

fenstrat → credited larowlan → .

Committed.

This broke D10 testing as only the 3.x branch of dynamic_entity_reference is D10 ready, this should fix that.

+++ b/composer.json
@@ -10,7 +10,7 @@
+        "drupal/dynamic_entity_reference": "~1 || ~2 || ~3",

Can you add 4 here too for those running v2

Haa sure! Almost did but noticed 4 wasn't stable. But adding it now makes sense.

Looks like the testbot is flaky (have tried a few runs), will try running again later.

Just ran these locally and they're passing for me, the preview_site is not a directory issue the bot is having looks to be bot specific.

I have applied the patch to fix some phpcs issue please review

@himanshu_jhaloya can you create a new issue for PHPCS please.

After searching around Re the failure in #12 it looks like this because of the changes to composer.json, and is a bot specific issue. We've actually hit it before with this module in ✨ Add a drush command for rebuilding preview sites Needs work , and others have in #3159928-19: uriScheme() method missing after update to Drupal 9 → - both make changes to composer.json. As to why it happens, not sure. So I'm going to commit and then run the branch test, hopefully they pass.

After the commit tests on 9.5 passed → but failed on 10.0 → . Undefined constant "FILE_STATUS_PERMANENT" in preview_site_s3 - looks like the bot didn't pick up all the needed changes? Taking a look now.

Looks like this should do it.

Adds missing ->accessCheck(TRUE) to content entity queries.

Missed an accessCheck on a getAggregateQuery,

Updates the visibility condition as node_type is removed in D10.

The last submitted patch, 23: 3289138-23.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

This time with the correct context.

Committed! Branch tests are passing on 9.5 and 10.0, yay.

Will cut a new release.

Automatically closed - issue fixed for 2 weeks with no activity.