- 🇮🇳India yogeshsevak
Providing updated patch with fixes. Please review.
- Status changed to Needs work
about 1 year ago 11:30am 24 May 2023 - 🇮🇳India Bushra Shaikh
Applied patch #6
Tested with Rector
Tested with Drupal Check and got errors.------ --------------------------------------------------------------------- Line prefetcher.drush.inc ------ --------------------------------------------------------------------- 50 Function drush_get_option not found. � Learn more at https://phpstan.org/user-guide/discovering-symbols 51 Function drush_get_option not found. � Learn more at https://phpstan.org/user-guide/discovering-symbols 52 Function drush_get_option not found. � Learn more at https://phpstan.org/user-guide/discovering-symbols 53 Function drush_get_option not found. � Learn more at https://phpstan.org/user-guide/discovering-symbols 54 Function drush_get_option not found. � Learn more at https://phpstan.org/user-guide/discovering-symbols ------ --------------------------------------------------------------------- ------ ------------------------------------------------------------- Line prefetcher.module ------ ------------------------------------------------------------- 104 Variable $prefetcher_uri in PHPDoc tag @var does not exist. 118 Variable $prefetcher_uri in PHPDoc tag @var does not exist. 120 Call to an undefined method Drupal\Core\Entity\EntityInterface::setPath(). 121 Call to an undefined method Drupal\Core\Entity\EntityInterface::jumpTheQueue(). 135 Variable $prefetcher_uri in PHPDoc tag @var does not exist. 137 Call to an undefined method Drupal\Core\Entity\EntityInterface::setPath(). 138 Call to an undefined method Drupal\Core\Entity\EntityInterface::jumpTheQueue(). 201 Call to an undefined method Drupal\Core\Entity\EntityInterface::set(). 202 Call to an undefined method Drupal\Core\Entity\EntityInterface::set(). 203 Call to an undefined method Drupal\Core\Entity\EntityInterface::jumpTheQueue(). ------ ------------------------------------------------------------- ------ --------------------------------------------------------------------- Line src\Commands\PrefetcherCommands.php ------ --------------------------------------------------------------------- 11 Class Drupal\prefetcher\Commands\PrefetcherCommands extends unknown class Drush\Commands\DrushCommands. � Learn more at https://phpstan.org/user-guide/discovering-symbols ------ --------------------------------------------------------------------- ------ ----------------------------------------------------------------------- Line src\Form\PrefetcherUriForm.php ------ ----------------------------------------------------------------------- 47 Method Drupal\prefetcher\Form\PrefetcherUriForm::save() should return int but return statement is missing. ------ ----------------------------------------------------------------------- ------ -------------------------------------------------------------------------- Line src\Plugin\PrefetcherCrawler\CrawlerBasic.php ------ -------------------------------------------------------------------------- 189 Access to an undefined property Drupal\Core\Field\FieldItemInterface::$value. � Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 316 Anonymous function has an unused use $responses. 322 Anonymous function has an unused use $responses. 347 Call to an undefined method Drupal\Core\Form\FormInterface::getConfig(). ------ -------------------------------------------------------------------------- ------ -------------------------------------------------------------------------- Line src\PrefetcherCrawlerManager.php ------ -------------------------------------------------------------------------- 71 Access to an undefined property Drupal\prefetcher\PrefetcherCrawlerManager::$config. � Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 71 Call to an undefined method Drupal\prefetcher\PrefetcherCrawlerManager::getType(). ------ -------------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line src\PrefetcherImporterService.php ------ ---------------------------------------------------------------------- 129 Method Drupal\prefetcher\PrefetcherImporterService::read() has invalid return type Drupal\prefetcher\str. 129 Parameter $options of method Drupal\prefetcher\PrefetcherImporterService::read() has invalid type Drupal\prefetcher\str. 184 PHPDoc tag @param references unknown parameter: $redirect_array 198 Variable $prefetcher_uri in PHPDoc tag @var does not match assigned variable $prefetcherUriEntityManager. 200 Call to an undefined method Drupal\Core\Entity\EntityInterface::setPath(). 216 Variable $prefetcher_uri in PHPDoc tag @var does not match assigned variable $prefetcherUriEntityManager. 218 Call to an undefined method Drupal\Core\Entity\EntityInterface::setUri(). 248 Parameter $row of method Drupal\prefetcher\PrefetcherImporterService::prefetcherUriExists() has invalid type Drupal\prefetcher\str. 271 Parameter $row of method Drupal\prefetcher\PrefetcherImporterService::prefetcherPathExists() has invalid type Drupal\prefetcher\str. ------ ---------------------------------------------------------------------- ------ -------------------------------------------------------------------------- Line src\PrefetcherUriHtmlRouteProvider.php ------ -------------------------------------------------------------------------- 46 Method Drupal\prefetcher\PrefetcherUriHtmlRouteProvider::getCollectionRoute() should return Symfony\Component\Routing\Route|null but return statement is missing. 71 Method Drupal\prefetcher\PrefetcherUriHtmlRouteProvider::getSettingsFormRoute() should return Symfony\Component\Routing\Route|null but return statement is missing. ------ -------------------------------------------------------------------------- ------ ----------------------------------------------------------------------- Line src\Service\Prefetcher.php ------ ----------------------------------------------------------------------- 161 Static method Drupal::logger() invoked with 2 parameters, 1 required. 172 Static method Drupal::logger() invoked with 2 parameters, 1 required. 204 Static method Drupal::logger() invoked with 2 parameters, 1 required. 226 Static method Drupal::logger() invoked with 2 parameters, 1 required. 255 Static method Drupal::logger() invoked with 2 parameters, 1 required. ------ ----------------------------------------------------------------------- [ERROR] Found 39 errors
- Status changed to Needs review
about 1 year ago 9:08am 23 June 2023 - 🇮🇳India Ashutosh Ahirwal India
Providing patch with fixes.
Please review.