- 🇨🇦Canada adam-vessey PE, Canada
Gave things a bit of a run over on D10 proper.
Test procedure, approximately: - up'd D10 ddev env - `ddev composer require mglaman/composer-drupal-lenient cweagans/composer-patches` - `ddev composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/migrate_directory"]'` - `ddev composer config --merge --json extra.patches '{"drupal/migrate_directory": {"D10 Supports": "https://www.drupal.org/files/issues/2022-06-16/migrate_directory.2.0.0.rector.patch"}}'` - `ddev composer require drupal/migrate_directory` - added a migration to a module (migrate_directory, in my testing, creating it a `migrations` directory, with a `test_migration.yml`): ``` --- id: test_migration label: Test Migration source: plugin: directory path: . destination: plugin: "null" ``` - ran bit of test code to check if things appear to be iterating in any capacity: ``` <?php /** @var \Drupal\migrate\Plugin\MigrationPluginManagerInterface $pmm */ $pmm = \Drupal::service('plugin.manager.migration'); $test_migration = $pmm->createInstance('test_migration'); /** @var \Drupal\migrate\Plugin\MigrateSourcePluginManager $pmms */ $pmms = \Drupal::service('plugin.manager.migrate.source'); $instance = $pmms->createInstance('directory', [ 'path' => '.', ], $test_migration); var_dump(iterator_count($instance)); $instance = $pmms->createInstance('directory', [ 'path' => '.', 'pattern' => '/.twig/', ], $test_migration); var_dump(iterator_count($instance)); ``` - output: ``` int(16567) int(970) ```
Very much a synthetic test, just seeing that it appears to iterate over _something_ and that it can filter, but looks like things should be fine for D10.
- 🇪🇨Ecuador cacrody
cacrody@gmail.com → made their first commit to this issue’s fork.