- First commit to issue fork.
- @henokmikre opened merge request.
- πΉπThailand Nick Hope
I'm preparing a site for upgrading from D9.5.11 to D10.2.
When I try to apply this with composer I get a
No valid composer.json was found...
error.The other D10-compatibility MR at https://www.drupal.org/project/media_taxonomy_filter/issues/3406755 π Automated Drupal 10 compatibility fixes with composer file Needs review will apply with Composer, because it includes a composer.json file, but it gives me Page Not Found, with no error messages, on pages using this module.
That other MR uses
$plugins['entity:taxonomy_term']['class'] = 'Drupal\taxonomy\Plugin\views\argument_validator\TermName';
inmedia_taxonomy_filter.views.inc
, whereas the one in #5 here uses$plugins['entity:taxonomy_term']['class'] = 'Drupal\views\Plugin\views\argument_validator\Entity';
.I don't have the experience to know which of
...\argument_validator\TermName
or...\argument_validator\Entity
is correct or preferable in this case. - πΊπΈUnited States henokmikre
@Nick, according to https://www.drupal.org/node/3221870 β , the correct validator is
\Drupal\views\Plugin\views\argument_validator\Entity
, so this patch should work for you. Here is one way to get this working: first ensure your composer.json is valid before adding this patch. Then add the following to the top of your "repositories" line:{ "type": "package", "package": { "name": "drupal/media_taxonomy_filter", "version": "dev-8.x-2.x", "type": "drupal-module", "source": { "type": "git", "url": "https://git.drupalcode.org/project/media_taxonomy_filter.git", "reference": "b0352483691533d69605b35e17491336fea4b2f1" } } },
Then add this in the "require" section:
"drupal/media_taxonomy_filter": "dev-8.x-2.x",
. You should then be able to runcomposer install
. - 065a7afb committed on 1.0.x
Issue #3288527, #3406755 by rakesh.nimje84@gmail.com, henokmikre,...
- 065a7afb committed on 1.0.x
- Status changed to Fixed
11 months ago 8:22am 4 January 2024 Hello, i just made a drupal 10 release.
you can install it with:
composer require 'drupal/media_taxonomy_filter:^3.0@beta'
Thank you guys for your help.
- πΉπThailand Nick Hope
@henokmikre Thank you for that. That installed the dev version but I would still need a patch on top of that. Anyway it doesn't matter because of the new release from olivier.br.
@olivier.br Thank you very much. It works for me. Unfortunately media_taxonomy_filter.info.yml is missing the info that is normally added by the Drupal.org packaging script:
version: '3.0.0-beta1' project: 'media_taxonomy_filter' datestamp: some number
So the module does not appear on /admin/reports/updates and there is no version number on /admin/modules etc..
I can raise a separate issue if you prefer.
- πΉπThailand Nick Hope
@olivier.br I've only ever done this once or twice but think it's to do with creating a release tag: https://www.drupal.org/docs/develop/git/git-for-drupal-project-maintaine... β
@Nick, that's exactly what i did to publish a new release.
After a try on my side to install the module on a new project with composer, i do have the packaging data included in the info.yml file:
# Information added by Drupal.org packaging script on 2024-01-04 version: '3.0.0-beta1' project: 'media_taxonomy_filter' datestamp: 1704356226
Maybe try to completely remove the module and to install it again ?
- πΉπThailand Nick Hope
@olivier.br Thank you. I did remove it and require it again with Composer and this time the info.yml file has the packaging data and the module appears on /admin/modules. It still doesn't appear on /admin/reports/updates, despite
drush cr
. I'm not sure why that would be. It's not the first time I've seen that happen. Does it appear on /admin/reports/updates for anyone else? Automatically closed - issue fixed for 2 weeks with no activity.