Automated Drupal 10 compatibility fixes

Created on 15 June 2022, about 2 years ago
Updated 27 October 2023, 8 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects β†’

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot β†’ official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot β†’ or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot β†’ , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue β†’ . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue β†’ .

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡―πŸ‡΄Jordan Rajab Natshah Jordan

    Had Real physical testing round for Image Resize Filter 1.0.x-dev with Drupal ~10 and Drupal ~9
    With CKEditor 4 and CKEditor 5

    Attached the steps to tests.
    Real-physical-testing-round-for-image_resize_filter-1-0-x-dev--with-d10-and-d9.zip β†’

    Build Drupal ~10.0 sandbox test site and have Drush ~11.0

    mkdir -p /var/www/html/sandboxes
    composer create-project drupal/recommended-project:~10.0 /var/www/html/sandboxes/drupal10image_resize_filter_1__test
    cd /var/www/html/sandboxes/drupal10image_resize_filter_1__test/
    composer require drush/drush:~11.0;
    

    Change minimum stability to dev for testing on the recommended Drupal 10 project template

    composer config minimum-stability dev
    

    Add CKEditor 4 for testing only

    composer require drupal/ckeditor:~1.0
    

    Add the Image Resize Filter module

    composer require 'drupal/image_resize_filter:1.x-dev@dev'
    

    Change file/directory mod and ownership of files:

    cd /var/www/html/sandboxes/drupal10image_resize_filter_1__test/
    sudo chmod 775 -R .;sudo chown www-data:$USER -R .;
    

    Install with Drush

    ./vendor/drush/drush/drush site:install standard --yes --site-name="Image Resize Filter 1.0.x-dev - Real physical testing with Drupal ~10" --account-name="webmaster" --account-pass="d" --account-mail="test@drupal.org" --db-url="mysql://root:123___@localhost/sandboxes_drupal10image_resize_filter_1__test" -vvv ;
    
    ./vendor/drush/drush/drush pm:enable image_resize_filter
    ./vendor/drush/drush/drush pm:enable ckeditor
    

    Rebuild the cache:

    sudo chmod 775 -R .;sudo chown www-data:$USER -R .;
    ./vendor/drush/drush/drush cache:rebuild
    

    Open a browser and change the address to: http://localhost/sandboxes/drupal10image_resize_filter_1__test/web/

    Using the module in many number of projects.

    • Using the Image Resize Filter only for migrated images from other systems, or from a very old D sites.
    • Managing CKEditor with media embed after Drupal 8/9 and now 10 .. not allowing to upload image files directly into the Text Format with CKEditor 4

    At this time the module is having issues with CKEditor 5 default image placement system. In both Drupal ~9.0 and ~10.0.

    The issue is with the width value of percentage width or physical pixel width.

    Example test case with Drupal 10 and CKEditor 5

    <p>
        Image resized 1
    </p>
    <p>
        <img src="/sandboxes/drupal10image_resize_filter_1__test/web/sites/default/files/inline-images/coworking-2.jpg" data-entity-uuid="594b1d41-a2eb-4b59-bcde-62f1674bcbf7" data-entity-type="file" alt="Test caption" width="38.34%" height="198">
    </p>
    <p>
        Image resized 2
    </p>
    <p>
        <img src="/sandboxes/drupal10image_resize_filter_1__test/web/sites/default/files/inline-images/coworking-2.jpg" data-entity-uuid="594b1d41-a2eb-4b59-bcde-62f1674bcbf7" data-entity-type="file" alt="Test caption" width="59.62%" height="330">
    </p>
    <p>
        Image resized original size
    </p>
    <p>
        <img src="/sandboxes/drupal10image_resize_filter_1__test/web/sites/default/files/inline-images/coworking-3.jpg" data-entity-uuid="dbb9034e-2b53-463f-9583-feba012f5ece" data-entity-type="file" alt="">
    </p>
    

    In CKEditor 5 - Edit

    After Saving with a text format which uses CKEditor 5

    My opinion on this module will be best used for CKEditor 4 only not with CKEditor 5

  • πŸ‡―πŸ‡΄Jordan Rajab Natshah Jordan

    Following on the conversation at πŸ“Œ Should this module be marked as Obsolete? Active

    Using the module in many number of projects.
    And it will could be needed in number of cases.

    • Using the Image Resize Filter only for migrated images from other systems, or from a very old D sites.
    • Managing CKEditor with media embed after Drupal 8/9 and now 10 .. not allowing to upload image files directly into the Text Format with CKEditor 4

    At this time the module

    My opinion on this module will be best used for CKEditor 4 which it is working will with Drupal 9/10
    Not to use with CKEditor 5, because of a conflict issues with CKEditor 5 default image placement system. In both Drupal ~9.0 and ~10.0.

  • πŸ‡―πŸ‡΄Jordan Rajab Natshah Jordan

    Hoping for a tag release.
    As stage when upgrading from Drupal 9 to Drupal 10
    or as a stage when changing from old CKEdtor 4 configs to CKEditor 5 configs.

  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States Mohammed J. Razem Santa Clara, CA
Production build 0.69.0 2024