- First commit to issue fork.
- @m4olivei opened merge request.
- Status changed to Needs review
about 2 years ago 7:24pm 2 March 2023 - 🇨🇦Canada m4olivei Grimsby, ON
A couple things I found. First, the module doesn't work in Drupal 10 (or 9.5 for that matter) due to a Javascript issue. I filed and issue and a fix for that in 🐛 Unlock dialog does not go away on Claro / 9.5.4 and 10.0.4 Fixed . This is blocked on that ticket.
Second, I also found a Symfony code deprecation that affects the module here. Symfony deprecated that method in 5.x and removed it in 6.x, that's probably why the prject update bot missed it? In any case, it's a simple fix.
Finally, given I needed to bump the version requirement for the fix in 🐛 Unlock dialog does not go away on Claro / 9.5.4 and 10.0.4 Fixed , and also that there is an open issue for bumping it in 📌 Declare correct module dependencies Fixed , I've done that ^9.2 version requirment bump here as well since I was touching it anyway.
See merge request. Thanks!
- Status changed to Fixed
about 2 years ago 6:14am 19 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.