Automated Drupal 10 compatibility fixes

Opened a merge request and then also added a couple of other small fixes for static code analysis flags set off by drupal-check.

This commit introduced a lot usages of $this when not in object context

I created a separate issue https://www.drupal.org/project/entity_reference_preview/issues/3346721 🐛 Several usages of $this when not in object context Fixed

Closing this as fixed. The regression introduced here is covered by 🐛 Several usages of $this when not in object context Fixed .

Automatically closed - issue fixed for 2 weeks with no activity.

Can this be reopened until the PR is merged into a release branch, or the -dev version? Until at least the core_version_requirements are updated in the .info file, a composer install of this project in a new or upgraded D10 will not work because it checks the version before it tries to apply any sort of patch.

I ran into this issue myself. This MR is now out-of-date, though it does have some needed Drupal 10 changes. Should we open a new issue to address Drupal 10 and close that MR?

In any case, I've created a patch against 1.0.8 for the Drupal 10 upgrade. I've also fixed most of the automated tests. I've done some manual testing and everything seems to work. However, I'd like to get some other people's feedback as I'm not super familiar with this module.

When applying this patch you're going to run into issues getting it to apply because it doesn't play nice when you try to update entity_reference_preview.info.yml. Add this to your composer.json.

  "config": {
   ..........
    "preferred-install": {
      "drupal/entity_reference_preview": "source",
      "*": "auto"
    }
  }

More details about this can be found here: https://chromatichq.com/insights/patching-info-files-composer/

A new issue 📌 Add Drupal 10 support Active and MR has been opened for this.