- Assigned to mark_fullmer
- 🇺🇸United States mark_fullmer Tucson
The most recent patch doesn't apply. Additionally the `core:8.x` value will need to be removed for D10 compatibility.
Finally, there is the problem that going forward, the `ckeditor` module is no longer in core -- now it is contrib at https://drupal.org/project/ckeditor, so the dependency on `drupal:ckeditor` will not work for D10 sites, but changing it to `ckeditor:ckeditor` will not work for D9 sites. So, I suggest we relocate the check for `ckeditor` into the hook_requirements implementation.
This is distinct from CKEditor 5 support, at which point, we should update the requirement to check for the presence of *either* `ckeditor` or `ckeditor5`.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:37pm 27 January 2023 - 🇺🇸United States mark_fullmer Tucson
I functionally verified that with the attached patch, this module can be enabled on a D10 site (when the `ckeditor` contrib module is also enabled) and works identically to the module's D8/D9 functionality. Per the comment above, the requirement check for `ckeditor` is moved to the `hook_requirements` implementation.
- 🇨🇦Canada smulvih2 Canada 🍁
Thanks for your work on this guys! I made a 2.1.0 release with these changes so people can start testing. Once this is verified to be working on D9 and D10 as expected I'll make the 2.1.0 release the suggested release. Thanks!
- Status changed to Fixed
over 1 year ago 3:28pm 17 February 2023 - 🇺🇸United States emerham
The new check to ensure CKEditor is installed causes my Install Profile to fail.
I have a custom Install Profile that Lists both CKEdtior and this module along side others and I cannot install a new site with the checks. Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 11:25am 5 April 2023 ckeditor module is no longer maintained because of EOL of ckeditor4
https://www.drupal.org/project/ckeditor →
shouldn't this module be compatible with ckeditor5 to be Drupal 10 ready?- 🇺🇸United States mark_fullmer Tucson
shouldn't this module be compatible with ckeditor5 to be Drupal 10 ready?
It certainly feels like that, but the contrib module for CKEditor4 can be used with Drupal 10, so technically, contributed modules can only provide CKEditor 4 backwards compatibility and otherwise be D10-compatible.
In many contrib projects I've seen, CKEditor 5 support is handled separate from D10 compatibility. For this module, the issue is ✨ CKEditor 5 Compatibility Fixed .
shouldn't this issue stay open for the update bot?
The Project Update Bot only posted "additional fixes as they became available" during the 9.x/10.x development cycle. Now that 10.0.0 has been released, there are no new things being deprecated.
sounds to me, that for now, you get D10 compatibility, until CKEditor4 is EOL...
but you are right, maybe focusing on https://www.drupal.org/project/ckeditor_div_manager/issues/3322722 ✨ CKEditor 5 Compatibility Fixed would be nice.