Automated Drupal 10 compatibility fixes

What do the maintainers think about this? We need a D10 release as this could be a blocker for many projects. Thanks!

Here's a patch after manually testing on Drupal 10. I also manually ran drupal-check against the code-base in Drupal 10 to see if there was anything that I missed in my manual testing. That uncovered a few more accessCheck calls I had missed in my manual testing. But it works in D10!

I also had to apply 📌 Automated Drupal 10 compatibility fixes Fixed to get that required dependency able to install.

Since the D10 compatibility patch depends on services that were introduced in 9.X.Y versions, this version range MUST NOT be valid. The minimum required Drupal core version MUST be reconsidered.

+core_version_requirement: ^8.7.7 || ^9 || ^10

That's true. Here's a more accurate representation of the supported version of Drupal core now.

Time Formatter now has a stable D10 release. I think all that is left is manual review and RTBC for _this_ issue. No further blockers.

Hi @heddn,

Thanks for the patch, I've reviewed it, looks okay so I've pushed to dev.
I've also changed the access checks to false, just to keep the original functionality.

Changing access check to false is a regression. The default is true.

You are right, I was just checking the current version that defaults to NULL if accessCheck() not called explicitly that's why I assumed it was "falsey" by default.

FTR, it is TRUE since 8.0.x by default, behavior changed from 9.2.0 where it defaults to NULL and requires the accessCheck() to called explicitly.

I'm going to change it back.

I'm going to mark this ticket as fixed. A new 3.2.0 release is available that has the Drupal 10 compatibility.

Automatically closed - issue fixed for 2 weeks with no activity.