Bug Drupal Coding Standard

Created on 28 May 2022, almost 3 years ago
Updated 21 February 2023, about 2 years ago

Hi @mandclu
I have check coding standard for module. You can check and fix it.

$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/content_moderation_link

FILE: C:\Ampps\www\Test-Drupal-Buiding\web\modules\contrib\content_moderation_link\content_moderation_link.module
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------


FILE: C:\Ampps\www\Test-Drupal-Buiding\web\modules\contrib\content_moderation_link\README.md
--------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
 60 | WARNING | Line exceeds 80 characters; contains 89 characters
--------------------------------------------------------------------------------------------


FILE: C:\Ampps\www\Test-Drupal-Buiding\web\modules\contrib\content_moderation_link\src\Controller\ContentModerationLinkController.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AND 7 WARNINGS AFFECTING 18 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  23 | WARNING | [x] There must be no blank line following an inline comment
  23 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  39 | WARNING | [x] 'TODO: Redirect to configured destination.' should match the format '@todo Fix problem X here.'
  47 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  54 | WARNING | [x] 'TODO: Prevalidate IDs and process none if one is invalid and $skip_errors' should match the format '@todo Fix problem X here.'
  60 | ERROR   | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces
  87 | WARNING | [x] 'TODO: Throw warning?' should match the format '@todo Fix problem X here.'
  89 | WARNING | [ ] Code after the CONTINUE statement on line 88 cannot be executed
  92 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  95 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  97 | WARNING | [x] 'TODO: populate from config.' should match the format '@todo Fix problem X here.'
 102 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 108 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 4
 108 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 113 | WARNING | [x] 'TODO: Redirect to a configured destination.' should match the format '@todo Fix problem X here.'
 117 | ERROR   | [x] Missing function doc comment
 121 | ERROR   | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces
 130 | ERROR   | [x] Expected 1 blank line after function; 0 found
 131 | ERROR   | [x] The closing brace for the class must have an empty line before it
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 19 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Ampps\www\Test-Drupal-Buiding\web\modules\contrib\content_moderation_link\src\Form\SettingsForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 43 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
 59 | WARNING | [ ] Possible useless method overriding detected
 60 | WARNING | [x] 'TODO: validate that the destination, if provided, is a valid route.' should match the format '@todo Fix problem X here.'
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

Time: 350ms; Memory: 8MB

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇻🇳Vietnam LuongGiap

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024