- First commit to issue fork.
- 🇮🇳India ankitv18
@berdir as phpstan also reports this issue
As per #2 do we need to remove this form in the next release? - Status changed to Needs work
3 months ago 12:37pm 11 August 2024 - 🇨🇭Switzerland berdir Switzerland
There is no need for DI here, it just adds more phpstan messages at the moment. This is an entity form that uses the messenger trait, you can use messenger(), especially on dead code that nobody should be using anymore.
- Status changed to Needs review
3 months ago 2:38pm 11 August 2024 - 🇮🇳India ankitv18
Yeah it's a dead code ~~ so don't know whether this needs to be merged or whole form gets removed!!
- Status changed to Needs work
3 months ago 7:17pm 11 August 2024 - 🇨🇭Switzerland berdir Switzerland
You must use the messenger() method, not the property directly.
It is deprecated and scheduled for removal, but that will require a new major version, which will likely not happen soon if ever.
- Status changed to Needs review
3 months ago 4:31am 12 August 2024 - Status changed to Needs work
3 months ago 6:47pm 12 August 2024 - 🇺🇸United States tr Cascadia
No, shouldn't be
\Drupal::messenger()
, should be$this->messenger()
. Read what @berdir wrote in #11. - Status changed to Needs review
3 months ago 3:21am 13 August 2024