OrderProfile::propertyDefinitions() include base fields

Created on 4 May 2022, about 3 years ago
Updated 23 February 2023, over 2 years ago

Problem/Motivation

We have an issue that order shipping profiles are saved with empty address after updating Commerce API to 8.x-1.0-beta10.

I have found it happens since Drupal\commerce_api\Plugin\Field\FieldType\OrderProfile::propertyDefinitions() started including metatag fields to the returned list. While metatag fields are base fields they are not excluded as they are supposed to.

Steps to reproduce

  1. Set up a commerce site with Commerce API, Commerce Shipping and Metatag modules enabled and configured.
  2. Add a product to cart and go through checkout via UI as anonymous user.
  3. At the review step see no shipping address in the shipping information pane.
  4. Open order shipping profile as admin and see empty address fields in it.

Proposed resolution

We should reconsider how the base fields are excluded from the properties list.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇨🇾Cyprus alex.bukach

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024