Support Drupal 10 and update all use of deprecation in the Google Analytics Reports module

Created on 27 April 2022, over 2 years ago
Updated 23 January 2023, almost 2 years ago

Problem/Motivation

Drupal 10.0 development

Thank you so much for the Drupal Core team

Following with

Drupal 10.0.0 is coming soon. Help us test it today!

A snapshot to allow module and theme developers to test compatibility with the next major release. No upgrade path is provided between alpha releases and many additional changes will be included prior to 10.0.0.

Proposed resolution

  • Support Drupal ~10 and change all deprecated packages, classes, functions, asset libraries to the Drupal 10 way
  • Real physical testing with Drupal ~10
  • Automated upgrade to Drupal ~10

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release google_analytics_reports-8.x-3.0 , google_analytics_reports-4.0.0-alpha2

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3277448 : Support Drupal 10 and update all use of deprecation in the Google Analytics Reports module
📌 Task
Status

Fixed

Version

4.0

Component

All modules

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇯🇴Jordan Rajab Natshah Jordan
    
    CONTRIBUTED PROJECTS
    --------------------------------------------------------------------------------
    Google Analytics Reports 8.x-3.0-rc3
    Scanned on Tue, 01/17/2023 - 22:41.
    
    2 errors found. 2 warnings found. Avoid some manual work by using drupal-rector
    for fixing issues automatically or Upgrade Rector to generate patches.
    
    Drupal 10 compatibility
    
    modules/contrib/google_analytics_reports/google_analytics_reports.install:
    ┌─────────┬──────┬────────────────────────────────────────────────────────┐
    │ STATUS  │ LINE │                        MESSAGE                         │
    ├─────────┼──────┼────────────────────────────────────────────────────────┤
    │ Fix now │ 85   │ Call to deprecated function drupal_uninstall_schema(). │
    │         │      │ Deprecated in drupal:9.2.0 and is removed from         │
    │         │      │ drupal:10.0.0. No direct replacement is provided.      │
    │         │      │                                                        │
    └─────────┴──────┴────────────────────────────────────────────────────────┘
    
    modules/contrib/google_analytics_reports/google_analytics_reports_api/src/Form/G
    oogleAnalyticsReportsApiAdminSettingsForm.php:
    ┌──────────┬──────┬─────────────────────────────────────────────────────────┐
    │  STATUS  │ LINE │                         MESSAGE                         │
    ├──────────┼──────┼─────────────────────────────────────────────────────────┤
    │ Fix with │ 116  │ Call to deprecated function render(). Deprecated in     │
    │ rector   │      │ drupal:9.3.0 and is removed from drupal:10.0.0. Use     │
    │          │      │ Drupal\Core\Render\RendererInterface::render() instead. │
    │          │      │                                                         │
    └──────────┴──────┴─────────────────────────────────────────────────────────┘
    
    modules/contrib/google_analytics_reports/google_analytics_reports.info.yml:
    ┌──────────┬──────┬────────────────────────────────────────────────────────────┐
    │  STATUS  │ LINE │                          MESSAGE                           │
    ├──────────┼──────┼────────────────────────────────────────────────────────────┤
    │ Check    │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
    │ manually │      │ compatible with the next major version of Drupal core. See │
    │          │      │ https://drupal.org/node/3070687.                           │
    │          │      │                                                            │
    └──────────┴──────┴────────────────────────────────────────────────────────────┘
    
    modules/contrib/google_analytics_reports/google_analytics_reports_api/google_ana
    lytics_reports_api.info.yml:
    ┌──────────┬──────┬────────────────────────────────────────────────────────────┐
    │  STATUS  │ LINE │                          MESSAGE                           │
    ├──────────┼──────┼────────────────────────────────────────────────────────────┤
    │ Check    │ 0    │ Value of core_version_requirement: ^8 || ^9 is not         │
    │ manually │      │ compatible with the next major version of Drupal core. See │
    │          │      │ https://drupal.org/node/3070687.                           │
    │          │      │                                                            │
    └──────────┴──────┴────────────────────────────────────────────────────────────┘
    
    
    
    
  • 🇯🇴Jordan Rajab Natshah Jordan

    Had Real physical testing round for Google Analytics Reports

    Attached the Bash files for the full testing round

    • 3.x-dev with Drupal ~9.0
    • 3.x-dev with Drupal ~10.0
    • 4.x-dev with Drupal ~9.0
    • 4.x-dev with Drupal ~10
  • Status changed to Fixed almost 2 years ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024