Code does not pass Drupal/DrupalPractice coding standards

Tested 3276291-4.patch 3 patch applied cleanly but 3 errors still remains

FILE: /opt/lampp/htdocs/testing/web/modules/contrib/visual_website_optimizer/visual_website_optimizer.help.inc
--------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------
 15 | ERROR | [x] list(...) is forbidden, use [...] instead.
 55 | ERROR | [x] list(...) is forbidden, use [...] instead.

FILE: /opt/lampp/htdocs/testing/web/modules/contrib/visual_website_optimizer/visual_website_optimizer.module
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Render\Markup.

Created the MR6 and fixed all remaining errors.

Thank you for your effort, but unable to use this MR due to the code base moving on to add new features.

To be able to have used this the MR needed to include multiple commits. ie. Keep the phpcbf run in it's own commit, manual fixes in their own commits, and then keep functional changes for another issue. This is the best aspect of MR over patches. It was much faster to just run phpcbf against the code base than picking through for usable parts.

MR also includes functionality changes which cause breakages, removes features, removed documentation. CS must not made actual changes to the module.

Unless I managed to miss any of the output of phpcs, this module should no longer have any issues. Postponing for now, but most likely closing this as outdated.

ELC → closed merge request !6

I noted earlier that there were functional changes included in these patches and MR. If there are any things that still need to be fixed, please open an issue for them.

Closing this issue as outdated.