PHP 7.4 Notice: Trying to access array offset on value of type null in field_widget_instance() when use in custom form

Problem/Motivation

When use link field widget in custom form → , start seeing following notice on PHP 7.4

Notice: Trying to access array offset on value of type null in field_widget_instance() (line 625 of /app/web/modules/field/field.form.inc)

Steps to reproduce

With PHP 7.4, use link widget on a custom form, see https://www.drupal.org/project/link/issues/2718563 → .

Proposed resolution

Instead of calling field_widget_instance() directly in link_field_process(), called field_form_get_state()and check for instance.

 function link_field_process($element, $form_state, $complete_form) {
-  $instance = field_widget_instance($element, $form_state);
+  $field_state = field_form_get_state($element['#field_parents'], $element['#field_name'], $element['#language'], $form_state);
+  $instance = !empty($field_state['instance']) ? $field_state['instance'] : array();

function field_widget_instance($element, $form_state) {
  $field_state = field_form_get_state($element['#field_parents'], $element['#field_name'], $element['#language'], $form_state);
  return $field_state['instance'];
}