Standardize update test fixtures for how to format terms

Created on 7 April 2022, over 2 years ago
Updated 7 August 2023, about 1 year ago

Problem/Motivation

The vast majority of update module release history test fixtures (from core/modules/update/tests/fixtures/release-history/*) do the following:

<term><name>Release type</name><value>Bug fixes</value></term>

Here's the count:

 egrep '<term><name' * | wc
    1125    4344  108623

In contrast, a very small number do this, instead:

                <term>
                    <name>Release type</name>
                    <value>Bug fixes</value>
                </term>

Here's that count:

% egrep '<term>$' * | wc
      38      76    1704

Hyper perfectionist Virgo nerd in me wants to clean these up and standardize on the condensed formatting. πŸ˜…

Steps to reproduce

  1. Open core/modules/update/tests/fixtures/release-history/drupal.sec.2.0.xml
  2. Be sad that it's not consistent with itself on how the stuff under <terms> is indented/formatted.
  3. Rightfully ask yourself "why does dww actually care about this?"

Proposed resolution

Make everything consistent.

Remaining tasks

  1. Do it.
  2. Reviews / refinements.

User interface changes

None.

API changes

Nope.

Data model changes

Nada.

Release notes snippet

N/A

πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component
UpdateΒ  β†’

Last updated about 9 hours ago

  • Maintained by
  • πŸ‡ΊπŸ‡ΈUnited States @tedbow
  • πŸ‡ΊπŸ‡ΈUnited States @dww
Created by

πŸ‡ΊπŸ‡ΈUnited States dww

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

  • πŸ‡³πŸ‡ΏNew Zealand quietone

    I do like consistency! However, this is a different format from the way the xmls from d.o are displayed, where each element is one a separate line. For me, it makes sense to make the test files look the same as the d.o release xmls when displayed in a browser. Just makes life a little easier when scanning the files, I think.

Production build 0.71.5 2024