Funding: Upgrade to Drupal 9

Created on 31 March 2022, over 2 years ago
Updated 18 April 2023, over 1 year ago

Problem/Motivation

Drupal.org will be upgrading to Drupal 9 at some point

Proposed resolution

Upgrade funding module to D9 APIs.

Remaining tasks

  • ✨ Funding: Implement Providers for D9 Fixed
    1. Upgrade custom widget
    2. Upgrade github widget
    3. Upgrade patreon widget
    4. Upgrade custom, github, patreon templates
  • πŸ“Œ Funding: Open Collective Widgets 2022 Closed: outdated
    1. Upgrade funding_open_collective_banner base module
    2. Upgrade funding_open_collective_banner widget
    3. Upgrade funding_open_collective_banner template
πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States liberatr Portland, OR

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States daggerhart
  • Status changed to Needs review over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States daggerhart

    This patch is a rebuild.

    I don't know the GitLab MR workflow, so it's a patch. To easily browse the code, I have it in GitHub also for now (2.x branch): https://github.com/daggerhart/funding

    Demo Site: https://dev-opencollective.pantheonsite.io/ (admin-light access available on request).

    New features:

    • Plugin Type: Funding Provider. Each funding provider is responsible for a namespace (specific key) in the funding yaml.
    • 11 Funding Providers in effort to have parity with GitHub's funding.yml in the core of this module.
    • Settings form allows admins to rearrange and disable Funding Providers.
    • Gallery page where admins can see examples for all funding providers.
    • Funding Examples are documented inline with the field.

    Open Collective

    The new Open Collective β†’ module adds many more Funding providers for this new branch of the funding module: https://git.drupalcode.org/project/opencollective/-/tree/1.0.x/src/Plugin/Funding/Provider

    • Badge
    • Contributors Image
    • Banner
    • Button
    • Contribution Flow
    • (API) Members - requires an API-Key be set in the oc_graphql_client module settings

    Each are as configurable as I could get make them (some of OC's documentation is incorrect).

    MVP Remaining TODOs

    1. I could not find any complete and working example of GitHub's, so I am not sure about all the URLs produced by the simple providers. Specifically, I need verified url patterns for the following: IssueHunt, KoFi, LfxMentorship, Liberapay, Otechie, Patreon, Tidelift
    2. Styling. Almost every visitor facing output is unstyled (or very lightly styled). Need some specific styling goals for the OOTB styles implementation.
    3. More documentation.
    4. Automated tests.
  • πŸ‡ΊπŸ‡ΈUnited States daggerhart

    Screenshots for 2.x patch:

  • πŸ‡ΊπŸ‡ΈUnited States daggerhart

    Updated patch adds some styles to the funding-link implementations.

  • First commit to issue fork.
  • @fjgarlin opened merge request.
  • Status changed to Needs work over 1 year ago
  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    I added all the above changes from #19 into an issue fork and MR. See here: https://git.drupalcode.org/project/funding/-/merge_requests/7/diffs

    The patch contained new image assets but as those are binary they're impossible to add, so please add them to the issue fork so we can better review and continue using the fork. The instructions to set up the fork are in the "Show commands" below the issue description.

    Once you've added the image assets we can continue the review.

  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    I made some minor comments to the MR, really minor things.

    After seeing the demo and the new features that this MR brings I think it should go directly into the module. It's a great refactoring, it's splitting things up to other modules where needed and it adds great functionality to the module. The gallery page is really good.

    I'd mark it as RTBC but not sure if somebody else will want to have a deeper look. I think that other minor things like styling suggestions/changes or additional plugins or any other features can be addressed in follow up issues. Also, as there are no releases yet, it's actually safe to merge.

    As mentioned via slack, we'll talk about this and other related issues next week, but wanted to at least mention that this MR is a really good refactoring + addition to the module. Great job!!

  • Issue was unassigned.
  • Status changed to RTBC over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States daggerhart

    After speaking with Tim, Fran, and Gus via Zoom call, we decided this was ready to merge.

  • Status changed to Fixed over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States daggerhart

    Merged and marking as Fixed.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024