- Status changed to Needs review
over 1 year ago 12:14pm 11 April 2023 - πΊπΈUnited States daggerhart
This patch is a rebuild.
I don't know the GitLab MR workflow, so it's a patch. To easily browse the code, I have it in GitHub also for now (2.x branch): https://github.com/daggerhart/funding
Demo Site: https://dev-opencollective.pantheonsite.io/ (admin-light access available on request).
New features:
- Plugin Type: Funding Provider. Each funding provider is responsible for a namespace (specific key) in the funding yaml.
- 11 Funding Providers in effort to have parity with GitHub's funding.yml in the core of this module.
- Settings form allows admins to rearrange and disable Funding Providers.
- Gallery page where admins can see examples for all funding providers.
- Funding Examples are documented inline with the field.
Open Collective
The new Open Collective β module adds many more Funding providers for this new branch of the funding module: https://git.drupalcode.org/project/opencollective/-/tree/1.0.x/src/Plugin/Funding/Provider
- Badge
- Contributors Image
- Banner
- Button
- Contribution Flow
- (API) Members - requires an API-Key be set in the oc_graphql_client module settings
Each are as configurable as I could get make them (some of OC's documentation is incorrect).
MVP Remaining TODOs
- I could not find any complete and working example of GitHub's, so I am not sure about all the URLs produced by the simple providers. Specifically, I need verified url patterns for the following: IssueHunt, KoFi, LfxMentorship, Liberapay, Otechie, Patreon, Tidelift
- Styling. Almost every visitor facing output is unstyled (or very lightly styled). Need some specific styling goals for the OOTB styles implementation.
- More documentation.
- Automated tests.
- πΊπΈUnited States daggerhart
Screenshots for 2.x patch:
- πΊπΈUnited States daggerhart
Updated patch adds some styles to the funding-link implementations.
- First commit to issue fork.
- @fjgarlin opened merge request.
- Status changed to Needs work
over 1 year ago 8:14am 12 April 2023 - πͺπΈSpain fjgarlin
I added all the above changes from #19 into an issue fork and MR. See here: https://git.drupalcode.org/project/funding/-/merge_requests/7/diffs
The patch contained new image assets but as those are binary they're impossible to add, so please add them to the issue fork so we can better review and continue using the fork. The instructions to set up the fork are in the "Show commands" below the issue description.
Once you've added the image assets we can continue the review.
- πͺπΈSpain fjgarlin
I made some minor comments to the MR, really minor things.
After seeing the demo and the new features that this MR brings I think it should go directly into the module. It's a great refactoring, it's splitting things up to other modules where needed and it adds great functionality to the module. The gallery page is really good.
I'd mark it as RTBC but not sure if somebody else will want to have a deeper look. I think that other minor things like styling suggestions/changes or additional plugins or any other features can be addressed in follow up issues. Also, as there are no releases yet, it's actually safe to merge.
As mentioned via slack, we'll talk about this and other related issues next week, but wanted to at least mention that this MR is a really good refactoring + addition to the module. Great job!!
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 4:26pm 18 April 2023 - πΊπΈUnited States daggerhart
After speaking with Tim, Fran, and Gus via Zoom call, we decided this was ready to merge.
-
daggerhart β
committed f3dfed3f on 1.x authored by
fjgarlin β
Issue #3272821: Funding: Upgrade to Drupal 9
-
daggerhart β
committed f3dfed3f on 1.x authored by
fjgarlin β
- Status changed to Fixed
over 1 year ago 4:29pm 18 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.