Update Style and eslint linting packages and node version to minimum of 16.0 and later in the Total Control Admin Dashboard module

Created on 30 March 2022, over 2 years ago
Updated 22 June 2023, about 1 year ago

Problem/Motivation

Proposed resolution

  • Remove scripts for old admin themes
  • Remove any JavaScript or CSS styling support for Internet Explorer (IE)
  • Remove plugin/no-browser-hacks from PostCSS or SCSS compiling
  • Follow with Drupal 10 core when compiling and linting CSS by browserslistrc
    last 2 Chrome major versions
    last 2 Firefox major versions
    last 2 Safari major versions
    last 2 Edge major versions
    last 2 Opera versions
    last 2 iOS major versions
    last 1 ChromeAndroid version
    last 1 UCAndroid version
    last 1 Samsung version
    Firefox ESR
    
  • Update the minimum node version to 16.0 and more
      "engines": {
        "yarn": ">= 1.6",
        "node": ">= 16.0"
      },
    

    Update the package.json file with

      "scripts": {
        "phpcs": "phpcs --standard=./.phpcs.xml .",
        "phpcbf": "phpcbf --standard=./.phpcs.xml .",
        "lint:yaml": "node ./node_modules/eslint/bin/eslint.js --config=.eslintrc.json --ext .yml .",
        "lint:css": "npx stylelint --config=.stylelintrc.json ."
      },
      "devDependencies": { 
        "eslint": "^8.9.0",
        "eslint-config-airbnb-base": "^15.0.0",
        "eslint-config-prettier": "^8.4.0",
        "eslint-plugin-import": "^2.25.4",
        "eslint-plugin-jquery": "^1.5.1",
        "eslint-plugin-prettier": "^4.0.0",
        "eslint-plugin-yml": "^1.2.0",
        "normalize.css": "8.0.x",
        "postcss": "^8.4.16",
        "postcss-header": "^3.0.2",
        "postcss-import": "^15.0.0",
        "postcss-preset-env": "^7.8.1",
        "postcss-pxtorem": "^6.0.0",
        "postcss-url": "^10.1.3",
        "prettier": "^2.1.2",
        "stylelint": "^14.0.1",
        "stylelint-checkstyle-formatter": "^0.1.2",
        "stylelint-config-standard": "^29.0.0",
        "stylelint-order": "^5.0.0"
      },
    

Remaining tasks

  • βœ… File an issue about this project
  • βœ… Addition/Change/Update/Fix to this project
  • βœ… Testing to ensure no regression
  • βž– Automated unit/functional testing coverage
  • βž– Developer Documentation support on feature change/addition
  • βž– User Guide Documentation support on feature change/addition
  • βž– Accessibility and Readability
  • βœ… Code review from 1 Varbase core team member
  • βœ… Full testing and approval
  • βœ… Credit contributors
  • βœ… Review with the product owner
  • βœ… Update Release Notes and Update Helper on new feature change/addition
  • βœ… Release total_control-3.0.4 β†’

Varbase update type

  • βœ… No Update
  • βž– Optional Update
  • βž– Forced Update
  • βž– Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3272522 β†’ : Updated Style and eslint linting packages and node version to minimum of 16.0 and later in the Total Control Admin Dashboard module
πŸ“Œ Task
Status

Fixed

Version

3.0

Component

Code

Created by

πŸ‡―πŸ‡΄Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024