- last update
over 1 year ago 143 pass, 8 fail - πΊπΈUnited States dcam
This patch is an attempt at getting the 1.x branch to pass tests. Here's a summary of the changes that were made:
- Removed the core version requirement from composer.json, as recommended by https://www.drupal.org/docs/develop/creating-modules/add-a-composerjson-... β . This also removed D10 compatibility for the branch, which was causing problems because it isn't compatible.
- Removed Color and RDF module checks from tests. I suspect that they were causing failures because those modules were removed from the standard profile, but to be honest I didn't dig into it.
- Changed the D6 block migration test to use Stark instead of Bartik. I just copied the same test from the 2.x branch for simplicity.
- last update
over 1 year ago 143 pass, 8 fail - last update
over 1 year ago Composer require failure - @dcam opened merge request.
- πΊπΈUnited States dcam
I'm not sure what's wrong here. It kind of looks like it didn't apply the patch when testing #5. So I decided to try a MR instead. To be honest, I don't use MRs very often. So I hopefully I'm doing this correctly.
- last update
over 1 year ago Composer require failure - last update
over 1 year ago Composer require failure - last update
over 1 year ago Composer require failure - last update
over 1 year ago 144 pass - πΊπΈUnited States dcam
Ok, my reading comprehension was either really bad when checking the errors for #5 or it's been too long since I've done any serious contribution work. Because it's obvious now what the problems are. In the end I literally just copied the same changes that were made for the 2.x branch in #3294389: Fix fails in HEAD β for the migrate_drupal_ui tests, stripping most of them out. They passed for me locally.
Oh, and I removed the changes to composer.json. I think maybe they can/should be tackled separately.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Nice, this should be heaps less brittle
- Status changed to Fixed
over 1 year ago 8:07pm 30 June 2023 - πΊπΈUnited States dcam
Since this was essentially a backport from 2.x I went ahead and committed it.
Automatically closed - issue fixed for 2 weeks with no activity.