- 🇨🇦Canada joelpittet Vancouver
This would be nice to have in a release if you have a moment. (I know, I have a few releases to make too 😅)
Php 8 is not supporting a required parameter after an optional one in method declaration and giving the below warnings in phpcs compatibility check
FILE: /var/www/docroot/sites/all/modules/contrib/admin_menu/tests/admin_menu.test
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
51 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter
| | $arguments is optional, while parameter $message is required.
72 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter
| | $arguments is optional, while parameter $message is required.
---------------------------------------------------------------------------------------------------------------Proposing the attached patch to fix the issue
Fixed
3.0
Code
The issue particularly affects sites running on PHP version 8.0.0 or later.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This would be nice to have in a release if you have a moment. (I know, I have a few releases to make too 😅)