Promote non-stable modules to the top of the list at admin/modules/uninstall form

Created on 18 March 2022, about 2 years ago
Updated 21 February 2023, over 1 year ago

Problem/Motivation

The module uninstall form lists all modules in alphabetical order, this means that non-stable modules are mixed in with stable modules.

In #3266397: Highlight non-stable modules on the admin/modules/uninstall form we are introducing the non-stable statuses for modules on the uninstall form.

During a UX calls it was identified that grouping such modules together at the top of the list would be preferable as it would draw more attention to them. This is particularly important for obsolete modules where immediate action may be required.

In #3266397-7: Highlight non-stable modules on the admin/modules/uninstall form it was agreed to push that change to a follow-up issue, this is that issue.

Steps to reproduce

Proposed resolution

For non-stable modules in the module uninstall list, promote those modules to the top of the list so that they appear first, then all other stable modules appear below in the list.

Remaining tasks

User interface changes

Before

After

API changes

None.

Data model changes

None.

Release notes snippet

Not needed.

📌 Task
Status

Fixed

Version

9.5

Component
Extension 

Last updated 3 days ago

No maintainer
Created by

🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇬🇧United Kingdom alexpott 🇪🇺🌍

    I think only "only deprecated and obsolete module are promoted." - since this is what you are likely to want to uninstall.

  • Status changed to Needs work over 1 year ago
  • 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland

    I think only "only deprecated and obsolete module are promoted." - since this is what you are likely to want to uninstall.

    Agreed, let's put this back to NW.

  • 🇺🇸United States dww

    Agreed. The original intention of my proposal was to promote the things you're most likely to want/need to uninstall to the top. That'd be only deprecated and obsolete, not experimental.

    Not sure if I should work on the patch now, or save my RTBC-ability... ;)

  • Status changed to Needs review over 1 year ago
  • 🇧🇷Brazil murilohp

    Not sure if I should work on the patch now, or save my RTBC-ability... ;)

    Keep it please hahaha, I was taking a look here and I think I can help, here's a new patch that excludes the obsolete and look just at the deprecated and obsolete lifecycles.

  • 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland

    Thanks @murilohp!

    Confirmed from a visual inspection that the most recent patch by @murilohp is pretty much the same as the previous one by @andregp, with the key difference being, as described, sorting only by deprecated and obsolete.

    I haven't tested that patch locally, but I did test the previous one, and since all the tests are passing, I'm happy to give a +1 to it.

    @dww if you're also happy with it then I think we're good to go to RTBC :)

    I do wonder if we need a change record or something for the release notes though?

  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States smustgrave

    Confirmed applying the patch #34 is sorting my deprecated modules.
    Tested with Activity tracker and Media Library Theme Reset

    Think a simple change record would be nice to just announce "hey modules are now sorted differently"

    Think this can go to RTBC after that.

  • Status changed to Needs review over 1 year ago
  • 🇧🇷Brazil murilohp

    Hey @smustgrave, I've added a new CR, moving back to NR.

  • Status changed to RTBC over 1 year ago
  • 🇺🇸United States smustgrave

    Thanks!

    • lauriii committed 642c614b on 10.1.x
      Issue #3270378 by andregp, murilohp, Rinku Jacob 13, AaronMcHale, dww,...
  • 🇫🇮Finland lauriii Finland

    I don't think issue needs a change record because there is no action required from our users. Users who are interested about changes on this level would likely follow the commits / issue queue.

    Committed 642c614 and pushed to 10.1.x. Thanks!

    I'm wondering if we should backport this to 10.0.x and 9.5.x. This seems like a low risk usability improvement to backport, but I could see how there could be a very low chance of tripping some automated tests.

    • lauriii committed 157ebea1 on 10.0.x
      Issue #3270378 by andregp, murilohp, Rinku Jacob 13, AaronMcHale, dww,...
    • lauriii committed 7c9a05d8 on 9.5.x
      Issue #3270378 by andregp, murilohp, Rinku Jacob 13, AaronMcHale, dww,...
  • Status changed to Fixed over 1 year ago
  • 🇫🇮Finland lauriii Finland

    Discussed with @alexpott and @catch on Slack and we agreed to backport this to 10.0.x and 9.5.x as a non-disruptive UX improvement.

  • 🇺🇸United States dww

    Fabulous, thanks everyone!

  • 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland

    Great to see this get in! Thanks everyone!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024