- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I think only "only deprecated and obsolete module are promoted." - since this is what you are likely to want to uninstall.
- Status changed to Needs work
almost 2 years ago 6:03pm 14 February 2023 - 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland
I think only "only deprecated and obsolete module are promoted." - since this is what you are likely to want to uninstall.
Agreed, let's put this back to NW.
- 🇺🇸United States dww
Agreed. The original intention of my proposal was to promote the things you're most likely to want/need to uninstall to the top. That'd be only deprecated and obsolete, not experimental.
Not sure if I should work on the patch now, or save my RTBC-ability... ;)
- Status changed to Needs review
almost 2 years ago 9:55pm 14 February 2023 - 🇧🇷Brazil murilohp
Not sure if I should work on the patch now, or save my RTBC-ability... ;)
Keep it please hahaha, I was taking a look here and I think I can help, here's a new patch that excludes the obsolete and look just at the deprecated and obsolete lifecycles.
- 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland
Thanks @murilohp!
Confirmed from a visual inspection that the most recent patch by @murilohp is pretty much the same as the previous one by @andregp, with the key difference being, as described, sorting only by deprecated and obsolete.
I haven't tested that patch locally, but I did test the previous one, and since all the tests are passing, I'm happy to give a +1 to it.
@dww if you're also happy with it then I think we're good to go to RTBC :)
I do wonder if we need a change record or something for the release notes though?
- Status changed to Needs work
almost 2 years ago 4:21pm 19 February 2023 - 🇺🇸United States smustgrave
Confirmed applying the patch #34 is sorting my deprecated modules.
Tested with Activity tracker and Media Library Theme ResetThink a simple change record would be nice to just announce "hey modules are now sorted differently"
Think this can go to RTBC after that.
- Status changed to Needs review
almost 2 years ago 5:06pm 19 February 2023 - 🇧🇷Brazil murilohp
Hey @smustgrave, I've added a new CR, moving back to NR.
- Status changed to RTBC
almost 2 years ago 6:39pm 19 February 2023 - 🇫🇮Finland lauriii Finland
I don't think issue needs a change record because there is no action required from our users. Users who are interested about changes on this level would likely follow the commits / issue queue.
Committed 642c614 and pushed to 10.1.x. Thanks!
I'm wondering if we should backport this to 10.0.x and 9.5.x. This seems like a low risk usability improvement to backport, but I could see how there could be a very low chance of tripping some automated tests.
- Status changed to Fixed
almost 2 years ago 12:03pm 20 February 2023 - 🇫🇮Finland lauriii Finland
Discussed with @alexpott and @catch on Slack and we agreed to backport this to 10.0.x and 9.5.x as a non-disruptive UX improvement.
- 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland
Great to see this get in! Thanks everyone!
Automatically closed - issue fixed for 2 weeks with no activity.