This is a follow up to #1578998: move forum topic and leave shadow cause duplicated topics show in list → to fix the reason that issue was re-opened. As explained in From #7 → from that issue.
As far as I can tell, this patch is relying on an accidental ordering of the database query in order to work. Which means that as soon as the query is actually ordered by something else, it breaks.
For example, you can click on any of the tablesort headers on the forum listing, and by doing that the node will flip back and forth between being displayed as a regular topic and shadow topic...
To be honest, that behavior is significantly less broken than what came before, so maybe this patch is an improvement anyway :) But we should be able to come up with a complete fix for this bug.
Patch
Review
Commit
Needs work
1.0
forum.module
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Forum is approved for removal. See #1898812: [policy] Deprecate forum module for removal in Drupal 11 →
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.
It will be moved to the contributed extension → once the Drupal 11 branch is open.