- Status changed to Needs review
over 1 year ago 7:39pm 16 August 2023 - πΊπΈUnited States mlncn Minneapolis, MN, USA
This has code seemingly ready to be committed so it is not only a support request anymore!
DrDam did you miss adding a new patch in your last comment five months ago? And how does this issue interplay with your new module https://www.drupal.org/project/media_contextual_crop β replacing multi_crop that you mentioned in comment 8?
Thanks!
- Status changed to RTBC
over 1 year ago 6:51am 17 August 2023 - π«π·France DrDam
Hi,
DrDam did you miss adding a new patch in your last comment five months ago?
There have been no changes since #7.
#13 are only an issue-meta updateHow does this issue interplay with your new modules replacing multi_crop that you mentioned in comment 8 ?
In the same way multi_crop, I just implement this hook_alter in the "media_contextual_crop_field_formatter" module to add crop settings in context.
As soon as the patch are merge, i'll clean the composer.json of my module - πΊπΈUnited States devkinetic
@mlcn https://git.drupalcode.org/project/media_contextual_crop_field_formatter...
"drupal/media_library_media_modify": { "#3270150 Add alteration": "https://www.drupal.org/files/issues/2022-06-08/manage_crops_3270150-7.patch" }
- Status changed to Needs work
2 months ago 9:51am 10 September 2024 - π¬π§United Kingdom alexpott πͺπΊπ
An alternate approach here would be for the module that needs the patch to decorate the
media_library_media_modify
service and make the changes it needs to \Drupal\media_library_media_modify\EntityReferenceOverrideService::getOverriddenValues - what speaks against this is the fact that \Drupal\media_library_media_modify\EntityReferenceOverrideService does not have an interface. Therefore I think that adding an alter seems okay and I guess it possible that other modules might need it too.It would be wonderful if an MR was created and if we added a media_library_media_modify.api.php file was created that describes the hook and why it should be used.
- Status changed to Needs review
2 months ago 12:20pm 12 September 2024 - π«π·France DrDam
I have create a second merge-request for 2.x branch