- 🇧🇪Belgium michaelsoetaert
Rerolled original patch to apply to latest version of the module (
3.0.3
). - 🇨🇴Colombia yovanny.gomez.oyola
I confirm that the patch works correctly with module version 3.0.3 and Drupal Core 10.4.7. Thanks.
- 🇧🇪Belgium bramvandenbulcke
I'm using this patch on a Drupal 11.1.7 website (Popup message version 3.0.3) and it's working great!
I think it's necessary to override the template, especially to:
- Add a role="dialog" for accessibility
- Change the h1 to a h2 or h3. Having an h1 on the dialog is a bad idea for SEO
- First commit to issue fork.
- Merge request !23Issue #3269851: Render the popup with a template → (Merged) created by UsingSession
-
usingsession →
committed a26de95d on 3.x
Issue #3269851: Render the popup with a template
-
usingsession →
committed a26de95d on 3.x
- 🇺🇦Ukraine UsingSession
Thank you for providing the patch. I’ve tested it, and it resolves the issue as expected.
So, I created the MR and merged it Automatically closed - issue fixed for 2 weeks with no activity.