Remove @todo in migration functional tests

Created on 28 February 2022, almost 3 years ago
Updated 31 August 2023, over 1 year ago

Postponed on πŸ“Œ Add content in tests only when needed Needs work

Problem/Motivation

Some migration functional tests create content before the migration and they should not be doing that,

There are @todos in Upgrade6Test and Upgrade7Test that can be done once πŸ“Œ Add content in tests only when needed Needs work is committed.

Steps to reproduce

Proposed resolution

Remove the deletion of content.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Closed: outdated

Version

1.0

Component

Code

Created by

πŸ‡³πŸ‡ΏNew Zealand quietone

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States dcam

    I don't understand this issue. I've been doing git and issue archaeology for the last hour to try and get the point because it doesn't make sense. At first I couldn't understand what @quietone was talking about because those aren't the class names of Aggregator's upgrade tests and never were. Also, neither test has a @todo and never did. But I understood that the migration tests were copied from migrate_drupal_ui so that they would continue working for Aggregator even after it was removed from Core. So I kept digging. While the copied tests were in development they did have the copied class names along with the @todo. All that was changed by @quietone in the MR with commit https://git.drupalcode.org/project/drupal/-/merge_requests/1849/diffs?co.... But that was nine days before this issue was created. So what's up with this?

    I think we can close this. It doesn't seem applicable. Also in πŸ“Œ Add content in tests only when needed Needs work @benjifisher asked at least twice if this issue could be closed as outdated without any response that I saw. If I'm wrong, then please feel free to re-open it, but please also explain exactly what needs to be done and where because I don't understand.

Production build 0.71.5 2024