Use of deprecated function

Seems the solution in #2 has been committed as part of https://www.drupal.org/node/3329297 → in alpha4, not tested it, but patch does not apply anymore, and code is updated: https://git.drupalcode.org/project/h5p/-/blob/2.0.0-alpha4/src/Plugin/Fi...

Marking needs work for a re-roll, and bumping to normal since the non-injection version went in with the overall Drupal 10 patch.

ShaunDychko → changed the visibility of the branch 3266331-use-of-deprecated to hidden.

The injected file_system service is used in the merge request.

Not sure from the comments but is this needed?

It's a low priority since this module doesn't have automated testing, but best practice is to inject the Drupal service instead of calling it statically. This is more of a code style issue (and maybe I should have opened a new issue.)

I made a very quick search in the code base and found 40 results in 13 files for \Drupal::service, so I think that this particular issue can be closed, as the php error will no longer happen, and then refactoring to use DI everywhere could be done in one or more new issues.

Yes, that makes sense. There are lots of code style issues and it might be easier to address them when the module is more stable.