Wrapper classes field should not be converted in the way currently implemented

Created on 24 February 2022, about 3 years ago

Updated 31 August 2023, over 1 year ago

Problem statement

String supplied for Wrapper classes field should not be converted in the way currently implemented. The help text "Separate classes with DOUBLE SPACES. Single spaces and much else will be converted to valid class name." will thus be removed. This "black box" approach gives rise to uncertainty for the website developer, e.g. what does "much else" mean?

Steps to reproduce

1) Add wrapper classes as "class-1 class-2"
2) Note that this is rendered as "class-1-class-2"
3) This is wrong.

Proposed resolution

Render the string entered in the "Wrapper classes" field as given, perhaps sanitized to remove possible security issues.

🐛 Bug report

Status

Fixed

Version

4.0

Component

Code

Created by

🇺🇸United States chuck_theobald

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇸United States smustgrave
Comment over 1 year ago →
🇺🇸United States smustgrave
Agree think comma separate makes more sense.

Leaving code for double space though for legacy sites.
@smustgrave opened merge request.
Comment over 1 year ago →
System Message

smustgrave → committed 96ee058d on 4.0.x
Issue #3266225: Wrapper classes field should not be converted in the way...
Status changed to Fixed over 1 year ago4:11pm 31 August 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024