Oauth2ClientService::getAccessToken() does not return the refreshed access token

Created on 23 February 2022, over 2 years ago

Updated 17 March 2023, over 1 year ago

Problem/Motivation

When an access token expires, the refresh_token Grant service can refresh it to create new valid access token. However, when called from Oauth2ClientService::getAccessToken() the $accessToken is overwritten by the void return value of Oauth2ClientGrantServiceInterface::getAccessToken()

Proposed resolution

Oauth2ClientService::getAccessToken() returns the refreshed access token.

Remaining tasks

Write a patch
Review
Commit

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Fixed

Version

3.0

Component

Code

Created by

🇳🇱Netherlands idebr

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇨🇭Switzerland berdir Switzerland
Note: This was undone again in #3255621: Generate access token, if Refresh token not exist → , which went back to expecting that the refresh grant service returns the access token. 4.x seems to have it fixed, so won't bother to open a new issue, this is just a workaround while we work on updating our site.
Comment over 1 year ago →
🇺🇸United States fathershawn New York
Ooh! sorry for the regression @Berdir and thanks for the patch to help those who need it get to 4.x :-)

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024