- π¦πΉAustria drunken monkey Vienna, Austria
Thanks for reporting this issue!
However, as I donβt use Behat, I have no idea whether this is really a problem or whether your solution makes sense. Iβll therefore have to wait until someone else confirms both the existence of the problem and that your MR resolves it.
(Also, please donβt use MRs in this project, as testing for them doesnβt work. Use a patch instead.) - last update
over 1 year ago 534 pass Hi,
First of all, I can confirm that the changes integrated following the https://www.drupal.org/project/search_api/issues/3115214 β issue and integrating the @search_api tag never worked for me.
I came across this issue and the fork made by Eduardo Morales Alberti and tried the code he proposed on my project and it works.
Needing a patch for this update and having seen drunken monkey's comment, I took the liberty of making a patch from the fork.
This one works well for me.Being new in the world of contribution, I hope I did things correctly and thank you in advance for your answers.
Have a nice day
- last update
over 1 year ago 534 pass - π¦πΉAustria drunken monkey Vienna, Austria
Welcome to the world of contribution, GrumpySchlag! And thanks for reporting back that this is indeed a problem, and fixed by the proposed changes.
Your patch is almost perfect, we just use indents of two spaces in Drupal, not four.
Also, going over the patch I noticed a few suboptimal bits about the original MR. Please test/review the attached patch and tell me if it still works correctly for you, then I can commit.
In any case, thanks again! Hi again,
I tried your patch and it still work for me.
Thanks !
-
drunken monkey β
committed 1696c211 on 8.x-1.x authored by
Eduardo Morales Alberti β
Issue #3263875 by Eduardo Morales Alberti, drunken monkey, GrumpySchlag...
-
drunken monkey β
committed 1696c211 on 8.x-1.x authored by
Eduardo Morales Alberti β
- π¦πΉAustria drunken monkey Vienna, Austria
Good to hear, thanks for reporting back!
Merged.
Thanks again, everyone! - Status changed to Fixed
over 1 year ago 1:30pm 12 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.