- Status changed to Fixed
over 1 year ago 9:40am 11 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to RTBC
11 months ago 6:29pm 9 December 2023 - 🇺🇸United States dcam
I suggest that this issue should be closed. Half the fixes were already made in 📌 Automated Drupal 10 compatibility fixes Fixed . The other half will be picked up by PHPStan when the module switches to using GitLabCI. So here's the plan I would do:
- Commit 📌 Adopt GitlabCi Downport . Maybe turn the PHPStan level down to 1 first.
- Make a new issue for fixing the PHPStan issues.
- Credit the people who worked on this issue in the new PHPStan issue.
- Close this.
- 🇩🇪Germany geek-merlin Freiburg, Germany
@dcam:
Thanks a lot for your help in triaging and issue gardening.Your #16 plan sounds good, so closing this. Another issue can be opened if needed.
> Maybe turn the PHPStan level down to 1 first.
You obviously know more than me about that, can you do that there?
- Status changed to Fixed
10 months ago 7:24pm 7 January 2024 - 🇺🇸United States dcam
Thanks a lot for your help in triaging and issue gardening.
No problem. IEF has been a favorite module of mine for a long time. It looked like you use a hand, so I want to pitch in.
You obviously know more than me about that, can you do that there?
Yep, it's done.
- 🇺🇸United States dcam
📌 Get PHPStan level 1 passing and enable automated test job Active is the new issue for granting credit.
Automatically closed - issue fixed for 2 weeks with no activity.