Some constraint messages are not translatable on localize.drupal.org

Created on 4 February 2022, almost 3 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

Some validation messages from Constraint classes are not translatable on localize.drupal.org

reference: #2884361: Missing translations for constraints β†’

* note: T_POTX_CONSTRAINT is marked for T_VARIABLE tokens inside .php files
* with the "Constraint" suffix, where the token is "$message", or ends
* with "Message"

So that means the variable which stores the constraint validation message should be $message or should end with Message.

There are numerous cases when the variable name does not match this requirement, like:
ModerationStateConstraint::$invalidTransitionAccess
DateTimeFormatConstraint::$badType
DateTimeFormatConstraint::$badFormat
DateTimeFormatConstraint::$badValue
ForumLeafConstraint::$selectForum
MenuSettingsConstraint:$messageWeight
MenuSettingsConstraint:$messageParent
MenuSettingsConstraint:$messageRemove

Steps to reproduce

Try to find these strings on localize.drupal.org.

Proposed resolution

Rename the variables with wrong name, to the unified format for potx to pick up.

Remaining tasks

- Find all occurrences of such variables in core and rename.
- Include the variable name restriction in Constraint documentation.

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
UI textΒ  β†’

Last updated 5 days ago

No maintainer
Created by

πŸ‡­πŸ‡ΊHungary pasqualle πŸ‡­πŸ‡Ί Budapest

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024