- 🇨🇦Canada joseph.olstad
I'm seeing this on cron invocations, wondering if it's related. We're using feeds.
- 🇳🇱Netherlands megachriz
I found the issue that introduced
renderRoot()in the code:
#2969259: Drush cron : can't print error messages →
There is an issue with using renderRoot in hook_help function, it throws following exception:
LogicException: A stray renderRoot() invocation is causing bubbling of attached assets to break.
1. Enable help block on admin pages
2. Open existing feed and go to mapping page
3. Blank page with fatal error is shown.
Rename renderRoot() method to render(). Not sure why renderRoot was used at all.
1. Needs review and testing if there are any side effects.
2. Need to be checked if render is needed in ajax callbacks - Drupal renders render arrays before sending data back.
3. Didn't change renderRoot calls inside tests
Needs work
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I'm seeing this on cron invocations, wondering if it's related. We're using feeds.
I found the issue that introduced renderRoot() in the code:
#2969259: Drush cron : can't print error messages →