Contrib.social

aria-label (link is external) for icon is not always true when using pattern matching

Open on Drupal.org →
Created on 26 January 2022, almost 3 years ago
Updated 26 June 2024, 6 months ago

When using pattern matching to open files in a new window, (pdf|doc|docx|xls|xlsx) for example, the aria-label for the icon is (link is external), which isn't accurate. It is an internal link opening in a new window/tab. Of course this isn't a major issue.

In our case since we don't reference any external files, so we are hiding the icon for files with css .file svg {display: none;}

💬 Support request
Status

Closed: works as designed

Version

1.0

Component

Miscellaneous

Created by

🇺🇸United States crutch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 6 months ago →
    🇺🇸United States smustgrave

    If I understand correctly you're using the module to open in new windows but not for external links? If that's the case not sure the module is written to cover such a scenario.

  • Comment 6 months ago →
    🇺🇸United States crutch

    ...hence the module name, External Links...sorry about that, closing. But yes, using this module to open files in new windows and that works as expected, thank you.

  • Status changed to Closed: works as designed 6 months ago
  • Comment 6 months ago →
    🇺🇸United States crutch
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024