The module's PHPUnit tests have some errors.

Open on Drupal.org →

Created on 14 January 2022, almost 3 years ago

Updated 2 May 2024, 8 months ago

Problem/Motivation

When I wanted to run the PHPUnit tests in the module I got the following error messages:

1) Drupal\Tests\rename_admin_paths\Functional\AccessTest::testAdminNotAccessibleAfterRenaming
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055 → , which includes recommendations on which theme to use.

2) Drupal\Tests\rename_admin_paths\Functional\AdminFormTest::testViewForm
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055 → , which includes recommendations on which theme to use.

3) Drupal\Tests\rename_admin_paths\Functional\AdminFormTest::testEnablePathReplacements
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055 → , which includes recommendations on which theme to use.

4) Drupal\Tests\rename_admin_paths\Unit\EventSubscriber\RenameAdminPathEventSubscriberTest::testGetSubscribedEvents
Error: Call to undefined method Drupal\Tests\rename_admin_paths\Unit\EventSubscriber\RenameAdminPathEventSubscriberTest::assertInternalType()

There was 1 risky test:

1) Drupal\Tests\rename_admin_paths\Functional\AccessTest::testAdminNotAccessibleAfterRenaming
This test did not perform any assertions

ERRORS!
Tests: 54, Assertions: 117, Errors: 4, Risky: 1.

Remaining self deprecation notices (2)

2x: Declaring ::setUp without a void return typehint in Drupal\Tests\rename_admin_paths\Functional\AdminFormTest is deprecated in drupal:9.0.0. Typehinting will be required before drupal:10.0.0. See https://www.drupal.org/node/3114724 →
2x in DrupalListener::startTest from Drupal\Tests\Listeners

Steps to reproduce

Check out the 8.x-2.x branch.
Run the module's tests.

🐛 Bug report

Status

Closed: outdated

Version

2.0

Component

Code

Created by

🇭🇺Hungary david.czinege

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Merge Requests

!3The module's PHPUnit tests have some errors.
Closed
🇭🇺Hungary david.czinege
updated 8 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Merge request !3Issue #3258659: The tests of the module are fixed. → (Closed) created by david.czinege
Comment over 1 year ago →
🇨🇦Canada endless_wander
These errors are blocking Drupal 10 upgrades as well so would be great to merge them.

I can confirm with the patch from this issue that the errors no longer appear and Upgrade Status module no longer reports these issues from the tests for upgrading to Drupal 10
Comment 8 months ago →
🇦🇺Australia darvanen Sydney, Australia
Interesting that this isn't happening in the gitlab pipeline: https://git.drupalcode.org/project/rename_admin_paths/-/merge_requests/1...

Perhaps this issue is a bit out of date?
Status changed to Closed: outdated 8 months ago6:26am 2 May 2024
Comment 8 months ago →
🇯🇵Japan ptmkenny
As per #5, tests are now passing. I looked over your code, and it seems similar changes have already been made to the 2.x branch. It's unfortunate that this work wasn't used when updating the module, but since the module tests already work again, I am closing this as outdated.
Comment 8 months ago →
System Message
ptmkenny → closed merge request !3

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024