Drupal\Tests\maestro_webform\Functional\LoadTest::testLoad fails

Created on 5 January 2022, over 3 years ago
Updated 12 February 2025, 3 months ago

Problem/Motivation

There is 1 test in this module. It is failing on Drupal 9.2 like this:

lum@maestro-d9-web:/var/www/html$ phpunit web/modules/contrib/maestro/
PHPUnit 9.5.11 by Sebastian Bergmann and contributors.

Testing /var/www/html/web/modules/contrib/maestro
E                                                                   1 / 1 (100%)R

Time: 00:04.817, Memory: 6.00 MB

There was 1 error:

1) Drupal\Tests\maestro_webform\Functional\LoadTest::testLoad
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to
 use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:436
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:561
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:381
/var/www/html/web/modules/contrib/maestro/modules/maestro_webform/tests/src/Functional/LoadTest.php:33
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

--

There was 1 risky test:

1) Drupal\Tests\maestro_webform\Functional\LoadTest::testLoad
This test did not perform any assertions

/var/www/html/web/core/tests/Drupal/Tests/Listeners/DrupalListener.php:127
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:450
/var/www/html/vendor/phpunit/phpunit/src/Util/PHP/AbstractPhpProcess.php:377
/var/www/html/vendor/phpunit/phpunit/src/Util/PHP/AbstractPhpProcess.php:187
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:678
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:678
/var/www/html/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:670
/var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:143
/var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:96

ERRORS!
Tests: 1, Assertions: 0, Errors: 1, Risky: 1.

Remaining self deprecation notices (2)

  1x: Declaring ::setUp without a void return typehint in Drupal\Tests\maestro_webform\Functional\LoadTest is deprecated in drupal:9.0.0. Typehinting will be
 required before drupal:10.0.0. See https://www.drupal.org/node/3114724
    1x in DrupalListener::startTest from Drupal\Tests\Listeners

  1x: The Drupal\Tests\maestro_webform\Functional\LoadTest::$modules property must be declared protected. See https://www.drupal.org/node/2909426
    1x in DrupalListener::startTest from Drupal\Tests\Listeners

Steps to reproduce

  1. setup a drupal installation to run phpunit
  2. run all test for maestro with something like this:
    phpunit web/modules/contrib/maestro/

Proposed resolution

Fix the test to make it pass.
Never get outdated tests again by activating Drupal CI / Automated testing for maestro.

Remaining tasks

  • Agree to activate Drupal CI
  • Activate it
  • Let the test pass on Drupal CI

User interface changes

none

API changes

none

Data model changes

none

πŸ“Œ Task
Status

Needs review

Version

4.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany luenemann SΓΌdbaden, Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024