- πΊπΈUnited States bernman
Patch applies cleanly and fixes the problem as specified.
Uses deprecated version of implode()
function. PHPCS returns the following errors:
FILE: ...es/all/modules/developer/missing_module/missing_module.drush.inc
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
106 | ERROR | Passing the $glue and $pieces parameters in reverse
| | order to implode has been deprecated since PHP 7.4 and
| | is removed since PHP 8.0; $glue should be the first
| | parameter and $pieces the second
----------------------------------------------------------------------
FILE: ...ites/all/modules/developer/missing_module/missing_module.install
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
53 | ERROR | Passing the $glue and $pieces parameters in reverse
| | order to implode has been deprecated since PHP 7.4 and
| | is removed since PHP 8.0; $glue should be the first
| | parameter and $pieces the second
----------------------------------------------------------------------
Run PHPCS to check the code:
phpcs -p . --standard=PHPCompatibility --runtime-set testVersion 8.0
Update implode function by switching the position of the parameters.
Drush command uses deprecated version of implode()
function. PHPCS returns the following error:
FILE: ...cts/t4a/public-site/sites/all/modules/contrib/missing_module/missing_module.drush.inc
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
106 | WARNING | Passing the $glue and $pieces parameters in reverse order to implode has
| | been deprecated since PHP 7.4; $glue should be the first parameter and
| | $pieces the second
-------------------------------------------------------------------------------------------
Run PHPCS to check the code:
phpcs -p . --standard=PHPCompatibility --runtime-set testVersion 7.4
Update implode function and switch the position of the parameters.
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Patch applies cleanly and fixes the problem as specified.