- π¦πΊAustralia acbramley
acbramley β changed the visibility of the branch 11.x to hidden.
- π¦πΊAustralia acbramley
acbramley β changed the visibility of the branch 3256828-chainflix-oembed-endpoint to hidden.
- Merge request !11930Issue #3256828: Handle schemes with special characters β (Open) created by acbramley
- πΊπΈUnited States smustgrave
Think we need a new MR as this got bit by the bug with gitlab
If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
- π¦πΊAustralia acbramley
Just need to rebase it or push a new commit.
You can comment
/rebase
on the MR to do that. - πΊπΈUnited States smustgrave
Didnβt know a simple comment could fix it. Good to know
Test only run shows the coverage. And donβt see any outstanding feedback
- π¬π§United Kingdom longwave UK
Some nits/suggestions. The sample regex-like URL confused me so I think we should add a comment explaining it.