Move the PostgreSQL Entity Query SQL code to the pgsql module

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Status changed to RTBC over 1 year ago12:16pm 16 January 2023
Status changed to Needs review over 1 year ago1:44pm 16 January 2023
Comment over 1 year ago →
🇳🇱Netherlands daffie
Changed the PostgreSQL override of the service entity.query.sql into one that decorates the original service instead of extending it. The workspaces module now has only to decorate the service entity.query.sql and no longer has to decorate the service pgsql.entity.query.sql.
Status changed to Needs work over 1 year ago3:37pm 30 January 2023
Comment over 1 year ago →
🇳🇱Netherlands Arantxio Dordrecht
Latest patch by @daffie removes the function register() mentioned by @xjm in comment #21. So we do not need a test for this anymore.

De rest of the changes are covered by the test and the test results are also all passed.

+++ b/core/core.services.yml @@ -1040,9 +1040,6 @@ services: - pgsql.entity.query.sql: - class: Drupal\Core\Entity\Query\Sql\pgsql\QueryFactory - arguments: ['@database']
We do remove this part, it could be that sites could perhaps break on this. I think it would be better if we do not remove this but instead change the name of the new service and make it non-public.

Also after some searching I can see that the dynamic_entity_reference module uses this service.

Comments & Activities