- Merge request !2Issue #3255663: Replace TWIG render with is not empty checks β (Merged) created by IT-Cru
- π©πͺGermany IT-Cru Munich
Added current state of MR as patch against 2.0-beta8 release before rebase.
- π©πͺGermany IT-Cru Munich
@twills: Diff of MR should apply again with 8.x-2.x-dev.
@thejimbirch @kerrymick: Is this change already addressed in development of 5.0.x branch?
- Status changed to Needs review
8 months ago 9:23am 27 March 2024 - First commit to issue fork.
-
kerrymick β
committed 5c910c17 on 8.x-2.x authored by
IT-Cru β
Issue #3255663: Replace TWIG render with is not empty checks
-
kerrymick β
committed 5c910c17 on 8.x-2.x authored by
IT-Cru β
- πΊπΈUnited States kerrymick Chicago
Thanks for the fix @IT-Cru! This does need to be fixed in the 5.0 branch. I will make an issue for that.
- Status changed to Fixed
8 months ago 6:09pm 28 March 2024 - π¨π¦Canada B.Friddy
There's one if check in the paragraph--bp-modal.html.twig on line 182 that is mispelled (stating 'it' instead of 'is')
{% if paragraph.bp_modal_footer it not empty %}
vs
{% if paragraph.bp_modal_footer is not empty %}
Just wondering if this could be updated (I believe I saw a similar statement in the 5.0.0 version as well)
- π©πͺGermany IT-Cru Munich
In MR to 5.0.x I can't find this issue. So it seems to be only related to 8.x-2.x branch.
If this is already included in latest release, I think it would be good to create a new issue as critical bug, because of this typo TWIG model template is broken.
Automatically closed - issue fixed for 2 weeks with no activity.