- 🇩🇪Germany Anybody Porta Westfalica
Thanks for the patch including important tests!
I guess we should first focus on 🐛 Implement support for content translation Fixed as that's a major issue. Once that's fixed, this one should be rerolled and fixed, too.
- 🇺🇸United States jsutta United States
Did some testing on this and the first patch worked for me in Drupal 10 with version 8.x-1.1 of the module installed. #5 seemed to have no effect on the module's behavior.
- 🇺🇸United States jsutta United States
Rerolled the patch against the latest version of the 8.x-1.x branch.
- last update
about 1 year ago 2 pass, 2 fail - 🇺🇸United States jsutta United States
Rerolled the patch after the latest release.
The last submitted patch, 9: 3254763-9.patch, failed testing. View results →
- Status changed to Needs work
about 1 year ago 5:33am 30 November 2023 - 🇩🇪Germany Anybody Porta Westfalica
Now that 🐛 Implement support for content translation Fixed is fixed, we should proceed here. Did others already try the patches here?
#9 tests still fail.Any maintainer feedback?
- 🇺🇸United States kurttrowbridge
I've been looking into this one because I'm having issues with a use case very similar to what's described in the original issue: a Media entity with two single-value File fields, one allowing PDFs and one allowing DOC/DOCX files.
Not sure if I'm just confused, but #9 doesn't seem to be addressing the use case of a Media entity with multiple File fields (not necessarily one or more multivalue fields), and seems more like it's addressing multivalue fields. #1 did seem to do so, so unless I'm missing anything on #9, my next attempt will be to fix the patch in #1 to work with the latest version of the module.
- @kurttrowbridge opened merge request.
- 🇺🇸United States kurttrowbridge
I did go back and work from the original patch to create a new one, and I think I now have a working solution that's ready for review; see the provided merge request. This should address the use case of a Media entity that contains multiple File fields (mine are a PDF and a DOCX, just like the case described in the original issue; both of mine are also single-value fields).
I'll attach a screenshot of my entity edit form as well, in which there's a "Replace file: ___" field for each file field, correctly identifying the field name and its allowed extensions.
I did a fair bit of testing with updating one or both files, with and without overwriting the file name, along with the creation of new Media entities, and didn't run into any issues. I would definitely appreciate additional reviews, though, especially given that I leaned on AI more than I typically do. Hopefully this will help for others as well.
Thanks!