UpdateSemverContribTest incorrectly sets core version

Open on Drupal.org →

Created on 7 December 2021, about 3 years ago

Updated 31 March 2024, 10 months ago

Problem/Motivation

In UpdateSemverContribTest::setProjectInstalledVersion(), we do this to set the installed version of Drupal core:

      'drupal' => [
        'project' => 'drupal',
        'version' => '8.0.0',
        'hidden' => FALSE,
      ],

This does not match the logic in update_test_system_info_alter(), which expects an #all key to set the core version (as seen in UpdateSemverCoreTest::setProjectInstalledVersion()).

So basically UpdateSemverContribTest is wrong here, and possibly passing falsely.

Steps to reproduce

N/A

Proposed resolution

Use the #all key to change the core version in UpdateSemverContribTest.

Remaining tasks

Post a test-only merge request which makes the change, just to see if any tests break, and which ones.

If no tests break, it means our coverage is lacking and we need to add some. If tests do break, fix them. This is what should be done in the second merge request.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

🐛 Bug report

Status

Closed: outdated

Version

11.0 🔥

Component

Last updated 11 days ago

Maintained by
🇺🇸United States @tedbow
🇺🇸United States @dww

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.

Bug Smash Initiative

Incomplete comments

Sign in to follow issues

Merge Requests

!1496UpdateSemverContribTest incorrectly sets core version
Open
🇺🇸United States phenaproxima
updated 10 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Merge request !1496Issue #3253149: UpdateSemverContribTest incorrectly sets core version → (Open) created by phenaproxima
Comment about 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Status changed to Closed: outdated 10 months ago6:25am 31 March 2024
Comment 10 months ago →
🇳🇿New Zealand quietone
I think this has been resolved by 📌 Create test trait to set update_test module settings Fixed . Therefor I am closing this as outdated. If that is incorrect re-open the issue and comment.

Thanks.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024