- đŠđŞGermany Anybody Porta Westfalica
Before closing this, what do you think about removing IE related code from a fresh 3.x branch fĂźr Drupal 10?
IE support was widely dropped (Google etc.) so we could do the same here with a 3.x for just Drupal 10. And for example entirely remove bLazy fallback for Intersection Observer API (IO) (
/admin/config/media/blazy
)What do you think? Separate issue as follow-up then?
- đŽđŠIndonesia gausarts
> removing IE related code from a fresh 3.x branch
We'll deprecate it at 3.x, and then removed at 4.x. If you don't use it, simply disable it at Blazy UI.One or two steps behind core, or picking up what was left out by core is what some modules usually do.
Aside I don't want too much more work nor regressions at 3.x. It was planned to remove VEF for core Media, and getting matured, or at least stabilized, a bit after the last dev storms.
-
gausarts â
committed 0a7fc2d7 on 8.x-2.x
- Issue #3253012 by Rajab Natshah, gausarts, Anybody: Drupal 10. - Added...
-
gausarts â
committed 0a7fc2d7 on 8.x-2.x
-
gausarts â
committed ceaebc6b on 8.x-2.x
Issue #3253012 by Rajab Natshah, gausarts, Anybody: Drupal 10
-
gausarts â
committed ceaebc6b on 8.x-2.x
-
gausarts â
committed d00b6d46 on 8.x-2.x
Issue #3253012 by Rajab Natshah, gausarts, Anybody: Drupal 10
-
gausarts â
committed d00b6d46 on 8.x-2.x
-
gausarts â
committed 3ff7a2f6 on 8.x-2.x
Issue #3253012 by Rajab Natshah, gausarts, Anybody: Drupal 10
-
gausarts â
committed 3ff7a2f6 on 8.x-2.x
- Status changed to Postponed
almost 2 years ago 7:27am 3 June 2023 - đŽđŠIndonesia gausarts
There are few more issues left, mostly related to sub-modules compatibility.
And thus needs pending till 3.x, or future sub-module updates, to avoid disruption. Such as:
Call to an undefined method Drupal\blazy\BlazyManagerInterface::build().
, etc.Around 70%+ out of 106 errors are not related to Blazy. Mostly the standing issues:
- đ Fix PHPStan L2 error "Variable $foo in PHPDoc tag @var does not exist. " Active
- đ Fix PHPStan L2 error "Call to an undefined method Drupal\Tests\WebAssert::{Method}" Postponed
- #3291519: [Meta] Fix 'Call to an undefined method' PHPStan L0 errors â
Line src/Form/BlazyEntityFormBase.php ------ ------------------------------------------------------------ 111 Call to an undefined method Drupal\Core\Entity\EntityInterface::set(). Line tests/src/FunctionalJavascript/BlazyFilterJavaScriptTest.php ------ ----------------------------------------------------------------------- 125 Call to an undefined method Drupal\Tests\WebAssert::waitForElement(). Line src/Media/BlazyFile.php ------ ---------------------------------------------------- 225 Variable $image in PHPDoc tag @var does not exist. 265 Variable $field in PHPDoc tag @var does not exist. ------ ------------------------------------------------------ Line src/Plugin/Filter/BlazyFilter.php ------ ------------------------------------------------------ 424 Call to an undefined method Drupal\blazy\BlazyManagerInterface::build(). 529 Call to an undefined method DOMNode::hasAttribute(). 530 Call to an undefined method DOMNode::getAttribute(). Line tests/src/Traits/BlazyCreationTestTrait.php (in context of class Drupal\Tests\blazy\Kernel\Views\BlazyViewsTestBase) ------ -------------------------------------------------------------------------- 236 Call to an undefined method Drupal\Core\Entity\EntityInterface::get(). ------ -------------------------------------------------------------------------- Line src/Plugin/Filter/BlazyFilterUtil.php ------ -------------------------------------------------------------------------- 208 Access to an undefined property DOMNamedNodeMap::$length.
They are core Drupal or PHP related issues, but unfortunately spit out in the checked modules causing confusions and unfair error counts.
Hopefully they fix them soon.Until 3.x is released, it is a Postponed.
Thanks.
-
gausarts â
committed c34c08c0 on 8.x-2.x
Issue #3253012 by Rajab Natshah, gausarts, Anybody: Drupal 10
-
gausarts â
committed c34c08c0 on 8.x-2.x
- Status changed to Fixed
over 1 year ago 8:21am 23 September 2023 - đŽđŠIndonesia gausarts
The last remaining tasks were done.
3.x was just out short after 2.17.
Thank you all contributions.
Automatically closed - issue fixed for 2 weeks with no activity.