- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 7:13am 6 September 2023 - 🇮🇳India prashant114606
Patch https://www.drupal.org/project/addtocalendar/issues/3251589#comment-1435... 🐛 JS runs multiple times creating performance issue Needs work is applied successfully.
Before
After applying patch
- Status changed to Needs work
over 1 year ago 5:47pm 6 September 2023 - 🇺🇸United States danflanagan8 St. Louis, US
If we're removing
js/addtocalendar.js
from the library definition, we should delete that file as well.I'm not 100% sure that's the right move though. What happens if something with an addtocalendar field gets loaded on the page through ajax? (Say an ajax View that shows Event nodes). Does the addtocalendar js run correctly with this patch? Or without the patch? I don't personally know. That's definitely something we would need to investigate before committing anything related to this issue.
- last update
10 months ago 1 pass - last update
10 months ago 1 pass